refactor(config): sw-690 rhel, satellite, openshift metric graph #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
force-pushed
the
sw-223-630-rhel
branch
3 times, most recently
from
5d054cb
to
ce8517e
Compare
cdcabrera
changed the title
cdcabrera
force-pushed
the
sw-223-630-rhel
branch
2 times, most recently
from
9fac743
to
a27eb46
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #1002 +/- ##
==========================================
- Coverage 93.91% 93.54% -0.37%
==========================================
Files 131 129 -2
Lines 4208 4215 +7
Branches 1663 1681 +18
==========================================
- Hits 3952 3943 -9
- Misses 237 254 +17
+ Partials 19 18 -1
Continue to review full report at Codecov.
|
cdcabrera
force-pushed
the
sw-223-630-rhel
branch
from
a27eb46
to
e7f2662
Compare
This was referenced Nov 17, 2022
cdcabrera
changed the title
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Nov 17, 2022
…ights#1002) * config, move to rhsmConstants from rhsmApiTypes
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Nov 17, 2022
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Nov 17, 2022
…HatInsights#1002) * config, rhel, satellite, openshift move to metric graph * toolbar, allow anything secondary fields * graphCardChart, cardHelpers, adjust callback data * productView, hosts, updated table condition * productViewContext, metric vs id uom filter
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Nov 17, 2022
* inventoryCard, state for parsed data * inventoryCardHelpers, productId for strings * inventoryGuests, move state to context * inventoryGuestsContext, infinite scroll, fix offset * inventoryReducer, types, clear guests data on close
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Nov 17, 2022
…Insights#1002) * config, rhel, openshift, satellite, inventory ids * locale, inventory strings * productView, allow updated hosts inventory * rhsmConstants, add missing sort types * rhsmTransformers, pass original props, number of guests
cdcabrera
force-pushed
the
sw-223-630-rhel
branch
from
e7f2662
to
28e21a7
Compare
…ights#1002) * config, move to rhsmConstants from rhsmApiTypes
…HatInsights#1002) * config, rhel, satellite, openshift move to metric graph * toolbar, allow anything secondary fields * graphCardChart, cardHelpers, adjust callback data * productView, hosts, updated table condition * productViewContext, metric vs id uom filter
* inventoryCard, state for parsed data * inventoryCardHelpers, productId for strings * inventoryGuests, move state to context * inventoryGuestsContext, infinite scroll, fix offset * inventoryReducer, types, clear guests data on close
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Nov 17, 2022
…Insights#1002) * config, rhel, openshift, satellite, inventory ids * locale, inventory strings * productView, allow updated hosts inventory * rhsmConstants, add missing sort types * rhsmTransformers, pass original props, number of guests
cdcabrera
force-pushed
the
sw-223-630-rhel
branch
from
28e21a7
to
845ade6
Compare
cdcabrera
commented
Nov 17, 2022
src/services/rhsm/__tests__/__snapshots__/rhsmConstants.test.js.snap
Outdated
Show resolved
Hide resolved
src/components/inventoryCard/__tests__/__snapshots__/inventoryCardContext.test.js.snap
Outdated
Show resolved
Hide resolved
…Insights#1002) * config, rhel, openshift, satellite, inventory ids * locale, inventory strings * productView, allow updated hosts inventory * rhsmConstants, add missing sort types * rhsmTransformers, pass original props, number of guests
cdcabrera
force-pushed
the
sw-223-630-rhel
branch
from
8bff574
to
8d94609
Compare
cdcabrera
added a commit
that referenced
this pull request
Nov 18, 2022
* config, move to rhsmConstants from rhsmApiTypes
cdcabrera
added a commit
that referenced
this pull request
Nov 18, 2022
cdcabrera
added a commit
that referenced
this pull request
Nov 18, 2022
* config, rhel, satellite, openshift move to metric graph * toolbar, allow anything secondary fields * graphCardChart, cardHelpers, adjust callback data * productView, hosts, updated table condition * productViewContext, metric vs id uom filter
cdcabrera
added a commit
that referenced
this pull request
Nov 18, 2022
* inventoryCard, state for parsed data * inventoryCardHelpers, productId for strings * inventoryGuests, move state to context * inventoryGuestsContext, infinite scroll, fix offset * inventoryReducer, types, clear guests data on close
cdcabrera
added a commit
that referenced
this pull request
Dec 5, 2022
* config, move to rhsmConstants from rhsmApiTypes
cdcabrera
added a commit
that referenced
this pull request
Dec 5, 2022
cdcabrera
added a commit
that referenced
this pull request
Dec 5, 2022
* config, rhel, satellite, openshift move to metric graph * toolbar, allow anything secondary fields * graphCardChart, cardHelpers, adjust callback data * productView, hosts, updated table condition * productViewContext, metric vs id uom filter
cdcabrera
added a commit
that referenced
this pull request
Dec 5, 2022
* inventoryCard, state for parsed data * inventoryCardHelpers, productId for strings * inventoryGuests, move state to context * inventoryGuestsContext, infinite scroll, fix offset * inventoryReducer, types, clear guests data on close
cdcabrera
added a commit
that referenced
this pull request
Dec 5, 2022
* config, rhel, openshift, satellite, inventory ids * locale, inventory strings * productView, allow updated hosts inventory * rhsmConstants, add missing sort types * rhsmTransformers, pass original props, number of guests
cdcabrera
added a commit
that referenced
this pull request
Dec 5, 2022
* config, move to rhsmConstants from rhsmApiTypes
cdcabrera
added a commit
that referenced
this pull request
Dec 5, 2022
cdcabrera
added a commit
that referenced
this pull request
Dec 5, 2022
* config, rhel, satellite, openshift move to metric graph * toolbar, allow anything secondary fields * graphCardChart, cardHelpers, adjust callback data * productView, hosts, updated table condition * productViewContext, metric vs id uom filter
cdcabrera
added a commit
that referenced
this pull request
Dec 5, 2022
* inventoryCard, state for parsed data * inventoryCardHelpers, productId for strings * inventoryGuests, move state to context * inventoryGuestsContext, infinite scroll, fix offset * inventoryReducer, types, clear guests data on close
cdcabrera
added a commit
that referenced
this pull request
Dec 5, 2022
* config, rhel, openshift, satellite, inventory ids * locale, inventory strings * productView, allow updated hosts inventory * rhsmConstants, add missing sort types * rhsmTransformers, pass original props, number of guests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
Commit
refactor(config): sw-690 rhel, satellite, openshift metric graph071f72e introduces a regression where bothsocketsandcorescolumns for inventory display at the same time for the OpenShift Container product display when run by itself see below example. Subsequent commits correct the issueit was noted to UX/design the placement of the granularity based filters would temporarily move, this is expected @mirekdlugosz
move RHEL, Satellite, and OpenShift et all product displays to the updated metric graph component.
How to test
Coverage and basic unit test check
$ yarn$ yarn testLocal run check
$ yarn$ yarn startExample
Metric graph component applied to RHEL, OpenShift and Satellite
standalone commit regression for OpenShift Container views
Updates issue/story
sw-690
fixes sw-689 @mirekdlugosz
relates sw-235 sw-223 sw-630