Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inventoryCard): sw-703 reset columns, rows #1010

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Nov 28, 2022

What's included

  • fix(inventoryCard): sw-703 reset columns, rows

Notes

  • quick fix to align inventory components
    • Need to review using the deep comparison on these against a lighter alternative, something like data response identifiers. We use a form of ID hash caching that could be leveraged here

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm that inventory displays reset and display the correct data when selecting granularity, granularity-like, and uom filters

Example

...

Updates issue/story

sw-703
relates sw-702 sw-235 sw-690

@cdcabrera cdcabrera added bug Something isn't working 202212 project phase labels Nov 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2022

Codecov Report

Merging #1010 (75e2e49) into dev (973b4bd) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1010      +/-   ##
==========================================
+ Coverage   93.52%   93.54%   +0.02%     
==========================================
  Files         129      129              
  Lines        4215     4216       +1     
  Branches     1681     1681              
==========================================
+ Hits         3942     3944       +2     
+ Misses        255      254       -1     
  Partials       18       18              
Impacted Files Coverage Δ
src/components/inventoryCard/inventoryCard.js 100.00% <100.00%> (ø)
...c/components/inventoryCard/inventoryCardContext.js 87.64% <100.00%> (ø)
...Subscriptions/inventoryCardSubscriptionsContext.js 81.63% <100.00%> (ø)
src/common/helpers.js 100.00% <0.00%> (+1.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 973b4bd...75e2e49. Read the comment docs.

@cdcabrera cdcabrera changed the title fix(inventoryCard): sw-702 reset columns, rows fix(inventoryCard): sw-703 reset columns, rows Nov 28, 2022
* inventoryCard, allow empty cols, rows
* inventoryCardContext, SubsContext, consistent response
@cdcabrera cdcabrera merged commit feea8f6 into RedHatInsights:dev Nov 28, 2022
cdcabrera added a commit that referenced this pull request Dec 5, 2022
* inventoryCard, allow empty cols, rows
* inventoryCardContext, SubsContext, consistent response
cdcabrera added a commit that referenced this pull request Dec 5, 2022
* inventoryCard, allow empty cols, rows
* inventoryCardContext, SubsContext, consistent response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202212 project phase bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants