Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(config): sw-722 activate rhel archs filter #1014

Merged
merged 3 commits into from
Dec 14, 2022

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Dec 3, 2022

What's included

  • refactor(config): sw-722 activate rhel archs filter

Notes

  • Activates RHEL architectures as a filter
  • This update should be coordinated with removal of the left navigation

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. navigate to RHEL all
  5. confirm the architectures toolbar filter exists and that it can be used to filter for RHEL architectures
    • if the left navigation exists it may have an odd behavior, throw errors, or simply not work... this is expected

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

Screen Shot 2022-12-02 at 10 30 01 AM
Screen Shot 2022-12-02 at 10 30 13 AM

Screen Shot 2022-12-02 at 10 48 19 PM
Screen Shot 2022-12-02 at 10 48 30 PM

Expected navigation using current structure
** surrounding links should be expected to alter between environments. the only links we directly control are underneath the Subscriptions section**

Screen Shot 2022-12-05 at 11 32 44 AM

Updates issue/story

sw-722
relates #1006 sw-630

@cdcabrera cdcabrera added the 202212 project phase label Dec 3, 2022
@cdcabrera cdcabrera changed the base branch from main to dev December 3, 2022 04:22
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2022

Codecov Report

Merging #1014 (958fabe) into dev (2891b10) will decrease coverage by 0.10%.
The diff coverage is 91.54%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1014      +/-   ##
==========================================
- Coverage   93.19%   93.09%   -0.11%     
==========================================
  Files         118      121       +3     
  Lines        3851     3966     +115     
  Branches     1547     1597      +50     
==========================================
+ Hits         3589     3692     +103     
- Misses        244      256      +12     
  Partials       18       18              
Impacted Files Coverage Δ
src/components/toolbar/toolbarFieldGranularity.js 100.00% <ø> (ø)
...c/components/toolbar/toolbarFieldSelectCategory.js 67.30% <0.00%> (-5.61%) ⬇️
src/components/toolbar/toolbarFieldUom.js 100.00% <ø> (ø)
src/config/product.rhel.js 72.34% <ø> (ø)
src/config/product.satellite.js 75.67% <ø> (ø)
src/config/routes.js 100.00% <ø> (ø)
src/components/toolbar/toolbarContext.js 86.48% <60.00%> (-10.34%) ⬇️
src/components/productView/productViewContext.js 97.87% <100.00%> (+0.57%) ⬆️
src/components/toolbar/toolbar.js 100.00% <100.00%> (ø)
src/components/toolbar/toolbarFieldArchitecture.js 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2891b10...958fabe. Read the comment docs.

@cdcabrera cdcabrera force-pushed the sw-630-activate-rhel-arch branch 2 times, most recently from ad4d221 to ce6fb80 Compare December 7, 2022 01:26
@cdcabrera cdcabrera changed the title refactor(config): sw-630 activate rhel archs filter refactor(config): sw-722 activate rhel archs filter Dec 7, 2022
@cdcabrera cdcabrera marked this pull request as ready for review December 12, 2022 23:12
@cdcabrera
Copy link
Member Author

related menu deactivation in stage-beta, RedHatInsights/cloud-services-config#1363

@mirekdlugosz
Copy link
Collaborator

When changing left nav, we should introduce analogous changes in deploy/frontend.yaml.

This file will be used to create menu in ephemeral environment, used as part of PR check. So the correct order of merges would be:

  • cloud-services-config is merged and deployed to stage-beta
  • iqe-curiosity-plugin PR is merged and tagged, so container is built
  • curiosity-frontend deploy/frontend.yaml changes are merged / sent as PR - PR check will use iqe-curisioty-plugin container image, which will now expect changed menu structure

But all three should happen close to each other. Otherwise, we risk spurious tests failures in Jenkins or PR check.

Since #1008 is not merged, we can introduce changes to deploy/frontend.yaml later.

@cdcabrera
Copy link
Member Author

we like the idea of just updating deploy/frontend.yaml as a separate commit with this PR... we'll go ahead and do it... and then activate the PR 1363 on the config side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202212 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants