-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(config): sw-722 activate rhel archs filter #1014
refactor(config): sw-722 activate rhel archs filter #1014
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #1014 +/- ##
==========================================
- Coverage 93.19% 93.09% -0.11%
==========================================
Files 118 121 +3
Lines 3851 3966 +115
Branches 1547 1597 +50
==========================================
+ Hits 3589 3692 +103
- Misses 244 256 +12
Partials 18 18
Continue to review full report at Codecov.
|
ad4d221
to
ce6fb80
Compare
ce6fb80
to
ea11e5a
Compare
ea11e5a
to
fba4af1
Compare
fba4af1
to
cc1c5a3
Compare
related menu deactivation in stage-beta, RedHatInsights/cloud-services-config#1363 |
When changing left nav, we should introduce analogous changes in This file will be used to create menu in ephemeral environment, used as part of PR check. So the correct order of merges would be:
But all three should happen close to each other. Otherwise, we risk spurious tests failures in Jenkins or PR check. Since #1008 is not merged, we can introduce changes to |
we like the idea of just updating |
f7aea40
to
def683b
Compare
What's included
Notes
How to test
Coverage and basic unit test check
$ yarn
$ yarn test
Proxy run check
$ yarn
$ yarn start:proxy
Check the build
$ yarn
$ yarn build
Example
Expected navigation using current structure
** surrounding links should be expected to alter between environments. the only links we directly control are underneath the
Subscriptions
section**Updates issue/story
sw-722
relates #1006 sw-630