-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(graphCard): sw-746 card styling #1032
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
force-pushed
the
sw-746
branch
4 times, most recently
from
January 10, 2023 16:43
632612e
to
6a39a89
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #1032 +/- ##
==========================================
+ Coverage 93.18% 93.19% +0.01%
==========================================
Files 122 122
Lines 4065 4071 +6
Branches 1657 1663 +6
==========================================
+ Hits 3788 3794 +6
Misses 260 260
Partials 17 17
Continue to review full report at Codecov.
|
cdcabrera
force-pushed
the
sw-746
branch
2 times, most recently
from
January 23, 2023 21:01
8e8583e
to
7207064
Compare
cdcabrera
force-pushed
the
sw-746
branch
2 times, most recently
from
February 3, 2023 19:58
bd7d64a
to
86d4673
Compare
cdcabrera
force-pushed
the
sw-746
branch
2 times, most recently
from
February 14, 2023 00:48
845df01
to
c878c82
Compare
cdcabrera
added a commit
that referenced
this pull request
Mar 2, 2023
* graphCard, adjust card keys * graphCardChart, remove minHeight div * graphCardMetricTotals, replace pf flex, styling, minHeight * styling, usage-graph adjustments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
How to test
Coverage and basic unit test check
$ yarn
$ yarn test
Local run check
$ yarn
$ yarn start
Proxy run check
$ yarn
$ yarn start:proxy
Example
Jan-09-2023.16-44-42.mp4
Updates issue/story
sw-746