Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(graphCard): sw-746 card styling #1032

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jan 6, 2023

What's included

  • refactor(graphCard): sw-746 card styling

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. navigate to the existing on-demand product displays and confirm their styling has been updated
    • confirm the remaining product displays are not affected

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. navigate to the existing on-demand product displays and confirm their styling has been updated
    • confirm the remaining product displays are not affected

Example

Jan-09-2023.16-44-42.mp4

Screen Shot 2023-01-06 at 3 50 06 PM
Screen Shot 2023-01-06 at 4 53 35 PM

Updates issue/story

sw-746

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2023

Codecov Report

Merging #1032 (7207064) into dev (63f75cb) will increase coverage by 0.01%.
The diff coverage is 87.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1032      +/-   ##
==========================================
+ Coverage   93.18%   93.19%   +0.01%     
==========================================
  Files         122      122              
  Lines        4065     4071       +6     
  Branches     1657     1663       +6     
==========================================
+ Hits         3788     3794       +6     
  Misses        260      260              
  Partials       17       17              
Impacted Files Coverage Δ
src/components/graphCard/graphCardChart.js 85.00% <66.66%> (ø)
src/components/graphCard/graphCardMetricTotals.js 95.12% <88.88%> (+0.83%) ⬆️
src/components/graphCard/graphCard.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63f75cb...7207064. Read the comment docs.

@cdcabrera cdcabrera merged commit 3a4694f into RedHatInsights:dev Feb 20, 2023
cdcabrera added a commit that referenced this pull request Mar 2, 2023
* graphCard, adjust card keys
* graphCardChart, remove minHeight div
* graphCardMetricTotals, replace pf flex, styling, minHeight
* styling, usage-graph adjustments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202304 project phase design Design specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants