Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): sw-728 virtualized to virtual #1062

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(locale): sw-728 rhel, satellite variant filters

Notes

  • quick fix, update virtualized to virtual

How to test

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. confirm the filters for both RHEL and Satellite toolbar display as Variant and Filter by variant, see examples below

Example

Screen Shot 2023-02-14 at 4 52 15 PM (2)

Updates issue/story

sw-728

@cdcabrera cdcabrera added the 202304 project phase label Feb 14, 2023
@jlprevatt
Copy link
Collaborator

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #1062 (20af62d) into dev (f7d299b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1062   +/-   ##
=======================================
  Coverage   93.56%   93.56%           
=======================================
  Files         122      122           
  Lines        4071     4071           
  Branches     1662     1662           
=======================================
  Hits         3809     3809           
  Misses        245      245           
  Partials       17       17           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7d299b...20af62d. Read the comment docs.

@cdcabrera cdcabrera merged commit d593ca9 into RedHatInsights:dev Feb 14, 2023
cdcabrera added a commit that referenced this pull request Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202304 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants