Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(productViewMissing): sw-625 local dev view, run #1071

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Mar 1, 2023

What's included

  • fix(productViewMissing): sw-625 local dev view, run

Notes

  • non blocking local developer workflow view and run
  • we ignored/disabled the local developer workflow to get the router updates out. this pr reactivates it
  • this may, or may not, throw an error in console in environment since routing is now tiered/nested with consoledot

How to test

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. confirm that the default card display appears at /app/subscriptions, and can be used to navigate between all available products, see example
    • note: the selected card attempts a url path closest match for product

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm routing/navigating between products remains unchanged
    • confirm manually navigating towards a url/path under subscriptions like [consoledot path]/subscriptions/lorem-ipusm/rhacs redirects to the closest product match without throwing a console error.
    • note: an end-user should never be able to directly receive the developer multi-card-product view

Example

Screen Shot 2023-03-02 at 4 18 16 PM

Updates issue/story

@cdcabrera cdcabrera added tech debt We've ignored it this long... 202304 project phase labels Mar 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2023

Codecov Report

Merging #1071 (22f2ce0) into dev (c553c74) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1071   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files         123      123           
  Lines        4113     4116    +3     
  Branches     1677     1678    +1     
=======================================
+ Hits         3845     3848    +3     
  Misses        251      251           
  Partials       17       17           
Impacted Files Coverage Δ
src/components/productView/productViewMissing.js 75.00% <100.00%> (+4.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c553c74...22f2ce0. Read the comment docs.

@cdcabrera cdcabrera marked this pull request as ready for review March 1, 2023 15:17
@cdcabrera
Copy link
Member Author

20230228 - 20230301 blocking due to env issues. Unable to confirm this fix is working

@cdcabrera cdcabrera added the blocked Prevented from continuing label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202304 project phase tech debt We've ignored it this long...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants