Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): npm updates #1081

Merged
merged 2 commits into from
Mar 14, 2023
Merged

fix(build): npm updates #1081

merged 2 commits into from
Mar 14, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Mar 14, 2023

What's included

  • fix(build): npm updates

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. confirm the product displays display as expected

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm the product displays display as expected

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

...

Updates issue/story

ongoing
sw-1030

@cdcabrera cdcabrera added the 202304 project phase label Mar 14, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1081 (008a449) into dev (03a07c2) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1081   +/-   ##
=======================================
  Coverage   93.61%   93.61%           
=======================================
  Files         121      121           
  Lines        4198     4198           
  Branches     1702     1702           
=======================================
  Hits         3930     3930           
  Misses        251      251           
  Partials       17       17           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03a07c2...008a449. Read the comment docs.

@cdcabrera cdcabrera merged commit 7509999 into RedHatInsights:dev Mar 14, 2023
cdcabrera added a commit that referenced this pull request Mar 21, 2023
cdcabrera added a commit that referenced this pull request Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202304 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants