Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(platformServices): sw-625 restore onNavigate #1085

Merged
merged 1 commit into from
Mar 20, 2023
Merged

fix(platformServices): sw-625 restore onNavigate #1085

merged 1 commit into from
Mar 20, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Mar 20, 2023 •
edited
Loading

What's included

  • fix(platformServices): sw-625 restore onNavigate

Notes

  • patch for routing, restores parts of the previous routing callback insights.chrome.on('APP_NAVIGATION', callback), currently scheduled for 8:00 AM EST

  • steps for release and testing

    • merge this PR to stage-stable to minimally confirm working and no errors
      • if errors, start over
      • if no errors, continue
    • subsequent PR and merge to bypass checks and move to prod
      • if errors, rollback to GUI v2.9.0
      • if no errors, continue
    • rollback and remove the bypass commit
    • release to prod-beta as v2.10.1-rc.0
    • release to prod-stable with release commit and v2.10.1
      • rebase accordingly

  • @mirekdlugosz @Hyperkid123

How to test

In environment check, stage and prod

  1. navigate and log into the appropriate environment
  2. confirm the behavior of navigating between
    • RHEL and Satellite updates the product view accordingly
    • OpenShift Container and OpenShift Dedicated updates the product view accordingly

Example

...

Updates issue/story

sw-625
RHCLOUD-24753

@cdcabrera cdcabrera added bug Something isn't working 202304 project phase labels Mar 20, 2023
@cdcabrera
fix(platformServices): sw-625 restore onNavigate
c74f315 
* authenticationContext, restore onNavigation callback
* platformActions, restore onNavigation
* redux, platformTypes, restore dispatch type
* services, restore onNavigation
@cdcabrera cdcabrera merged commit 68c6101 into RedHatInsights:main Mar 20, 2023
@cdcabrera cdcabrera mentioned this pull request Mar 20, 2023
Merged
@cdcabrera cdcabrera mentioned this pull request Apr 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
202304 project phase bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cdcabrera