Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bannerMessages): sw-884 generic banners #1094

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Apr 7, 2023

What's included

  • refactor(bannerMessages): sw-884 generic banners

Notes

  • removes the old cloudigrade messaging - cloud provider related
  • replaces the existing banner messages with some akin to toast messages, but banner messages... allows setting and removing
  • runs in the background until messages are required

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

...

Updates issue/story

sw-884

@cdcabrera cdcabrera added the 202304 project phase label Apr 7, 2023
@cdcabrera cdcabrera force-pushed the sw-884 branch 2 times, most recently from f8209ef to a68b580 Compare April 7, 2023 22:23
@cdcabrera
Copy link
Member Author

/retest

* bannerMessages, replace with generic banners
* bannerMessagesContext, hooks for remove, add banners
* productView, allow banner messages for all products
* redux, actions, types, reducer, restructure
@cdcabrera cdcabrera merged commit c4b52ca into RedHatInsights:dev Apr 11, 2023
cdcabrera added a commit that referenced this pull request Apr 21, 2023
* bannerMessages, replace with generic banners
* bannerMessagesContext, hooks for remove, add banners
* productView, allow banner messages for all products
* redux, actions, types, reducer, restructure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202304 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant