Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(toolbarFieldArchitecture): sw-748 remove component, 2 of 2 #1097

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Apr 10, 2023

What's included

  • refactor(toolbarFieldArchitecture): sw-748 remove component

Notes

  • no visual updates associated with this change
  • removes unused architecture related work, components and copy in favor of variant

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm RHEL and Satellite still have usable variant filters

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

...

Updates issue/story

related #1096
sw-747 sw-748

@cdcabrera cdcabrera added tech debt We've ignored it this long... 202304 project phase labels Apr 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2023

Codecov Report

Merging #1097 (5db69de) into dev (3c4de82) will decrease coverage by 0.08%.
The diff coverage is 88.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1097      +/-   ##
==========================================
- Coverage   93.59%   93.51%   -0.08%     
==========================================
  Files         121      121              
  Lines        4214     4166      -48     
  Branches     1704     1699       -5     
==========================================
- Hits         3944     3896      -48     
  Misses        253      253              
  Partials       17       17              
Impacted Files Coverage Δ
src/components/productView/productView.js 90.00% <ø> (-0.33%) ⬇️
src/components/toolbar/toolbar.js 100.00% <ø> (ø)
src/components/toolbar/toolbarContext.js 96.20% <ø> (-0.39%) ⬇️
...c/components/toolbar/toolbarFieldSelectCategory.js 68.51% <ø> (+2.44%) ⬆️
src/config/product.rhel.js 90.69% <ø> (ø)
src/redux/actions/rhsmActions.js 100.00% <ø> (ø)
src/redux/types/index.js 100.00% <ø> (ø)
src/redux/types/rhsmTypes.js 100.00% <ø> (ø)
src/services/rhsm/rhsmHelpers.js 100.00% <ø> (ø)
...components/bannerMessages/bannerMessagesContext.js 84.09% <82.05%> (+0.75%) ⬆️
... and 6 more

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c4de82...5db69de. Read the comment docs.

@cdcabrera cdcabrera marked this pull request as ready for review April 20, 2023 15:06
@cdcabrera cdcabrera merged commit 01e5eb2 into RedHatInsights:dev Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202304 project phase tech debt We've ignored it this long...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants