-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build checks, unit testing for i18n and commit messages #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ci #110 +/- ##
=======================================
Coverage 91.34% 91.34%
=======================================
Files 27 27
Lines 543 543
Branches 142 142
=======================================
Hits 496 496
Misses 38 38
Partials 9 9 Continue to review full report at Codecov.
|
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Oct 10, 2019
* commit message check, aids in changelog updates
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Oct 14, 2019
* commit message check, aids in changelog updates
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Oct 14, 2019
* commit message check, aids in changelog updates
* combined i18n tests to allow for easier snapshot updates
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Oct 14, 2019
* commit message check, aids in changelog updates
* commit message check, aids in changelog updates
* build, branch checkout to chrome repo clone, expand messaging * build, use NPM instead of yarn to build chrome to avoid errors * readme requirements updated to include NPM
cdcabrera
added a commit
that referenced
this pull request
Oct 14, 2019
* commit message check, aids in changelog updates
cdcabrera
added a commit
that referenced
this pull request
Oct 15, 2019
* commit message check, aids in changelog updates
cdcabrera
added a commit
that referenced
this pull request
Oct 15, 2019
* commit message check, aids in changelog updates
cdcabrera
added a commit
that referenced
this pull request
Oct 15, 2019
* commit message check, aids in changelog updates
cdcabrera
added a commit
that referenced
this pull request
Oct 23, 2019
* commit message check, aids in changelog updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
How to test
Coverage and basic unit test check
$ yarn
$ yarn test
Check the integration tests
$ yarn
$ yarn build
(the integration checks require some minor build output to function)$ yarn test:integration
i18n
test in the console outputCheck commits
$ yarn
$ yarn build
(the integration checks require some minor build output to function)$ yarn test:integration
Example
CI should pass
Updates issue/story
Ongoing