Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build checks, unit testing for i18n and commit messages #110

Merged
merged 3 commits into from
Oct 14, 2019

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Oct 8, 2019

What's included

  • fix(i18n): combine i18n integration and unit test
    • combined i18n tests to allow for easier snapshot updates
  • feat(build): commit message integration check
    • commit message check, aids in changelog updates
  • fix(build): issues/105 local run chroming update
    • build, branch checkout to chrome repo clone, expand messaging
    • build, use NPM instead of yarn to build chrome to avoid errors
    • readme requirements updated to include NPM

Notes

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test

Check the integration tests

  1. update the NPM packages with $ yarn
  2. $ yarn build(the integration checks require some minor build output to function)
  3. $ yarn test:integration
  4. you should no longer see the i18n test in the console output

Check commits

  1. update the NPM packages with $ yarn
  2. $ yarn build (the integration checks require some minor build output to function)
  3. make a silly commit that you can revert and that doesn't follow our git commit messaging guidelines, CONTRIBUTING.md#commits
  4. $ yarn test:integration
  5. the commit check should output to your console similar to

Screen Shot 2019-10-08 at 5 54 06 PM

Example

CI should pass

Updates issue/story

Ongoing

@codecov-io
Copy link

codecov-io commented Oct 8, 2019

Codecov Report

Merging #110 into ci will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #110   +/-   ##
=======================================
  Coverage   91.34%   91.34%           
=======================================
  Files          27       27           
  Lines         543      543           
  Branches      142      142           
=======================================
  Hits          496      496           
  Misses         38       38           
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0406801...a93fde8. Read the comment docs.

cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Oct 10, 2019
* commit message check, aids in changelog updates
@cdcabrera cdcabrera added the blocked Prevented from continuing label Oct 11, 2019
@cdcabrera cdcabrera removed the blocked Prevented from continuing label Oct 14, 2019
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Oct 14, 2019
* commit message check, aids in changelog updates
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Oct 14, 2019
* commit message check, aids in changelog updates
* combined i18n tests to allow for easier snapshot updates
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Oct 14, 2019
* commit message check, aids in changelog updates
* commit message check, aids in changelog updates
* build, branch checkout to chrome repo clone, expand messaging
* build, use NPM instead of yarn to build chrome to avoid errors
* readme requirements updated to include NPM
@cdcabrera cdcabrera merged commit 14932d5 into RedHatInsights:ci Oct 14, 2019
cdcabrera added a commit that referenced this pull request Oct 14, 2019
* commit message check, aids in changelog updates
cdcabrera added a commit that referenced this pull request Oct 15, 2019
* commit message check, aids in changelog updates
cdcabrera added a commit that referenced this pull request Oct 15, 2019
* commit message check, aids in changelog updates
cdcabrera added a commit that referenced this pull request Oct 15, 2019
* commit message check, aids in changelog updates
cdcabrera added a commit that referenced this pull request Oct 23, 2019
* commit message check, aids in changelog updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants