Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 of 3 - build(eslint): restructure linting #1103

Merged

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Apr 18, 2023

What's included

  • build(eslint): restructure linting

Notes

  • ...

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

...

Updates issue/story

blocked by #1104
ongoing
blocks #1107

@cdcabrera cdcabrera added build 202304 project phase labels Apr 18, 2023
@cdcabrera cdcabrera force-pushed the 20230412-build-eslint-restructure branch from 79f2489 to 805a698 Compare April 18, 2023 15:23
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023

Codecov Report

Merging #1103 (de75f47) into dev (cf889f3) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1103      +/-   ##
==========================================
- Coverage   93.54%   93.52%   -0.03%     
==========================================
  Files         122      121       -1     
  Lines        4212     4168      -44     
  Branches     1715     1699      -16     
==========================================
- Hits         3940     3898      -42     
+ Misses        255      253       -2     
  Partials       17       17              
Impacted Files Coverage Δ
src/components/chart/chart.js 90.90% <ø> (ø)
src/hooks/useWindow.js 84.61% <100.00%> (+1.28%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf889f3...de75f47. Read the comment docs.

@cdcabrera cdcabrera closed this Apr 18, 2023
@cdcabrera cdcabrera reopened this Apr 18, 2023
@cdcabrera cdcabrera force-pushed the 20230412-build-eslint-restructure branch 3 times, most recently from a3ae709 to fb7c416 Compare April 19, 2023 17:52
@cdcabrera
Copy link
Member Author

/retest

@cdcabrera cdcabrera changed the title build(eslint): restructure linting 2 of 2 - build(eslint): restructure linting Apr 20, 2023
@cdcabrera cdcabrera added the blocked Prevented from continuing label Apr 20, 2023
@cdcabrera cdcabrera changed the title 2 of 2 - build(eslint): restructure linting 2 of 3 - build(eslint): restructure linting Apr 20, 2023
@cdcabrera cdcabrera force-pushed the 20230412-build-eslint-restructure branch from de75f47 to b92a61a Compare April 21, 2023 17:05
@cdcabrera cdcabrera force-pushed the 20230412-build-eslint-restructure branch from b92a61a to 3cdb876 Compare April 24, 2023 19:10
@cdcabrera cdcabrera removed the blocked Prevented from continuing label Apr 24, 2023
@cdcabrera cdcabrera merged commit d51f560 into RedHatInsights:dev Apr 25, 2023
cdcabrera added a commit that referenced this pull request Apr 26, 2023
cdcabrera added a commit that referenced this pull request Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202304 project phase build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants