Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphCardHelpers): sw-925 billing category, unique ids #1139

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jun 15, 2023

What's included

  • feat(graphCardHelpers): sw-925 billing category, unique ids

Notes

  • expands the string keys/ids used to provide "unique" displays
  • this affects ALL product graph views, specifically the "graph card title" and the "graph title tooltip" (the question mark next to the title)
    • RHEL and variants
    • OpenShift and variants
    • RHACS
    • RHODS
    • formerly RHOSAK

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. confirm that no display copy for existing graph cards has changed

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm that no display copy for existing graph cards has changed

Example

...

Updates issue/story

sw-925
sw-922
#1138
blocks #1135

@cdcabrera cdcabrera changed the title fix(graphCardHelpers): sw-925 billing category, unique ids feat(graphCardHelpers): sw-925 billing category, unique ids Jun 15, 2023
@cdcabrera cdcabrera merged commit 94ddc36 into RedHatInsights:dev Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202308 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant