Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(config): sw-1215 reduce metric card mantissa #1142

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jun 20, 2023

What's included

  • refactor(config): sw-1215 reduce metric card mantissa

Notes

  • reduces the potential decimals displayed if a float is passed to the GUI.
    • it is understood that the API should now be passing an int with a math ceil on it
    • this GUI update does NOT prevent the display of a float, but instead reduces the number of potential decimal places.
      • this update helps retain the potential to display values such as 1.2K or 1.5M etc 1.23K or 1.52M etc
      • we can perform a subsequent fix for Number.parseIn(someValue, 10) if the API fails to pass the correct values
  • this affects the following product configurations
    • OpenShift Dedicated
    • OpenShift metrics
    • RHACS
    • RHODS
    • formerly RHOSAK
    • ROSA

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. once the API passes integers for these values
    • confirm the GUI responds by passing the expected integer value

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm the build checks come back clean

Example

...

Updates issue/story

sw-1215

@cdcabrera cdcabrera added the 202308 project phase label Jun 20, 2023
@cdcabrera cdcabrera changed the title fix(config): sw-1215 reduce metric card mantissa refactor(config): sw-1215 reduce metric card mantissa Jun 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2023

Codecov Report

Merging #1142 (c3395b7) into dev (0e8a3c4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1142   +/-   ##
=======================================
  Coverage   93.55%   93.55%           
=======================================
  Files         123      123           
  Lines        4362     4362           
  Branches     1797     1797           
=======================================
  Hits         4081     4081           
  Misses        261      261           
  Partials       20       20           
Impacted Files Coverage Δ
src/config/product.openshiftDedicated.js 82.22% <ø> (ø)
src/config/product.openshiftMetrics.js 81.39% <ø> (ø)
src/config/product.rhacs.js 89.79% <ø> (ø)
src/config/product.rhods.js 85.41% <ø> (ø)
src/config/product.rhosak.js 91.22% <ø> (ø)
src/config/product.rosa.js 83.78% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e8a3c4...c3395b7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202308 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants