Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): sw-1001 remove rosa from openshift variants #1157

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(config): sw-1001 remove rosa from openshift variants

Notes

  • patches OpenShift by removing ROSA from the available variant select/dropdown

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm ROSA is no longer available in the OpenShift variants listing

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

...

Updates issue/story

sw-1001

@cdcabrera cdcabrera added the 202308 project phase label Jul 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2023

Codecov Report

Merging #1157 (d0a53a8) into main (ff0a957) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1157   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files         123      123           
  Lines        4364     4364           
  Branches     1799     1799           
=======================================
  Hits         4082     4082           
  Misses        262      262           
  Partials       20       20           
Files Changed Coverage Δ
src/config/product.rosa.js 82.05% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff0a957...d0a53a8. Read the comment docs.

@cdcabrera cdcabrera merged commit dae9a69 into RedHatInsights:main Jul 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202308 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants