Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(config): sw-1565 remove rhosak #1161

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Aug 3, 2023

What's included

  • refactor(config): sw-1565 remove rhosak

Notes

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm RHOSAK is no longer able to be viewed
    • navigate towards /application-services/subscriptions/streams

Example

...

Updates issue/story

sw-1565
#1160

@cdcabrera cdcabrera added the 202308 project phase label Aug 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Merging #1161 (2e3d3a5) into main (2a5d19f) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1161      +/-   ##
==========================================
+ Coverage   93.48%   93.51%   +0.03%     
==========================================
  Files         122      121       -1     
  Lines        4219     4162      -57     
  Branches     1764     1732      -32     
==========================================
- Hits         3944     3892      -52     
+ Misses        255      250       -5     
  Partials       20       20              
Files Changed Coverage Δ
src/services/rhsm/rhsmConstants.js 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a5d19f...2e3d3a5. Read the comment docs.

@cdcabrera cdcabrera merged commit 123eb92 into RedHatInsights:main Aug 3, 2023
3 of 4 checks passed
cdcabrera added a commit that referenced this pull request Aug 8, 2023
cdcabrera added a commit that referenced this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202308 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants