fix(table): sw-1537 tableEmpty, apply empty table #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
commented
Sep 15, 2023
Codecov Report
@@ Coverage Diff @@
## main #1192 +/- ##
=======================================
Coverage 92.44% 92.45%
=======================================
Files 123 123
Lines 4238 4240 +2
Branches 1771 1769 -2
=======================================
+ Hits 3918 3920 +2
Misses 301 301
Partials 19 19 Continue to review full report in Codecov by Sentry.
|
* docs, correct table modules * locale, correct table strings * table, empty table props * tableEmpty, generate actual empty table * tableSkeleton, ariaLabel, summary props
cdcabrera
force-pushed
the
sw-1537-fixes
branch
from
a72a00e
to
76288e6
Compare
cdcabrera
added a commit
that referenced
this pull request
Sep 19, 2023
* docs, correct table modules * locale, correct table strings * table, empty table props * tableEmpty, generate actual empty table * tableSkeleton, ariaLabel, summary props
cdcabrera
added a commit
that referenced
this pull request
Sep 19, 2023
* docs, correct table modules * locale, correct table strings * table, empty table props * tableEmpty, generate actual empty table * tableSkeleton, ariaLabel, summary props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
How to test
Coverage and basic unit test check
$ yarn$ yarn testProxy run check
$ yarn$ yarn start:proxyCheck the build
$ yarn$ yarn buildExample
...
Updates issue/story
sw-1537