Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): sw-1692 activate rhel for x86 EUS #1216

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

vbusch
Copy link
Contributor

@vbusch vbusch commented Oct 16, 2023

What's included

feat(config): sw-1692 activate rhel for x86 EUS

Notes

Sorting automatically makes x86 EUS appear in the list

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm the product
  • appears in the variant list for RHEL
  • confirm ALL API calls now include the product ID rhel-for-x86-eus

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

Screenshot from 2023-10-16 09-40-30

Updates issue/story

sw-1692

related #1213

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

Merging #1216 (77142c1) into main (1a675ac) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1216   +/-   ##
=======================================
  Coverage   92.35%   92.35%           
=======================================
  Files         121      121           
  Lines        4198     4198           
  Branches     1753     1753           
=======================================
  Hits         3877     3877           
  Misses        302      302           
  Partials       19       19           
Files Coverage Δ
src/services/rhsm/rhsmConstants.js 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a675ac...77142c1. Read the comment docs.

Copy link
Member

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes to align the product identifier. Looks like you may also need to run the documentation generator

$ yarn build:docs

... and add the result to your commit. At some point we'll look at getting that added on merge without the need for human

public/locales/en-US.json Outdated Show resolved Hide resolved
public/locales/en-US.json Outdated Show resolved Hide resolved
public/locales/en-US.json Outdated Show resolved Hide resolved
public/locales/en-US.json Outdated Show resolved Hide resolved
src/services/rhsm/rhsmConstants.js Outdated Show resolved Hide resolved
@cdcabrera cdcabrera added the 202312 project phase label Oct 16, 2023
@vbusch vbusch force-pushed the swatch-1692-x86-eus branch 6 times, most recently from 57bdc93 to a35bd01 Compare October 16, 2023 18:11
@vbusch
Copy link
Contributor Author

vbusch commented Oct 16, 2023

/retest

Error: EMFILE: too many open files, open '/container_workspace/package.json'

Locally yarn test:deps is passing for me

@vbusch
Copy link
Contributor Author

vbusch commented Oct 16, 2023

/retest

Copy link
Member

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really close, just learning the diffs between tools =)

src/services/rhsm/rhsmConstants.js Outdated Show resolved Hide resolved
src/services/rhsm/rhsmConstants.js Outdated Show resolved Hide resolved
src/services/rhsm/rhsmConstants.js Outdated Show resolved Hide resolved
@cdcabrera
Copy link
Member

@vbusch everything is brought up to date and passing and passing review!

We're investigating an unrelated build issue around the charts before this merges. Once that issue is tracked down we'll look at hitting approve for confirmation

Signed-off-by: Vanessa Busch <vbusch@redhat.com>
@cdcabrera cdcabrera merged commit 1a35347 into RedHatInsights:main Oct 17, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202312 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants