Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): sw-1889 add rhel for x86 els payg #1224

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Oct 30, 2023

What's included

  • feat(config): sw-1889 add rhel for x86 els payg

Notes

  • A standalone configuration for payg RHEL Updated request to add to RHEL variants listing
  • If/when this is grouped under RHEL the description for RHEL products, variants, needs to be expanded to include the wording On-demand similar desc to OpenShift acknowledging the various subscription types available Monitor your Red Hat Enterprise Linux usage for both Annual and On-Demand subscriptions.
  • Uses a deprecated RHOSAK config as the basis for instances and subscriptions table displays Needs to use the RHACS single metric inventory display
    • Config is also blend of RHACS, RHODS, and OpenShift metrics

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm the RHEL x86 els payg product display appears like the attached example
    • navigate towards [proxy staging preview]/subscriptions/usage/rhel-for-x86-els-payg

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

Screen Shot 2023-11-02 at 3 39 01 PM
Screen Shot 2023-11-02 at 3 39 48 PM

Updates issue/story

@cdcabrera cdcabrera added the 202312 project phase label Oct 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Merging #1224 (baaad55) into main (a90cf3b) will decrease coverage by 0.19%.
The diff coverage is 78.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1224      +/-   ##
==========================================
- Coverage   92.35%   92.16%   -0.19%     
==========================================
  Files         121      122       +1     
  Lines        4198     4251      +53     
  Branches     1753     1786      +33     
==========================================
+ Hits         3877     3918      +41     
- Misses        302      314      +12     
  Partials       19       19              
Files Coverage Δ
src/services/rhsm/rhsmConstants.js 100.00% <ø> (ø)
src/services/rhsm/rhsmServices.js 100.00% <ø> (ø)
...c/components/inventoryCard/inventoryCardHelpers.js 81.81% <80.00%> (-0.73%) ⬇️
src/config/product.rhelElsPayg.js 78.00% <78.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a90cf3b...baaad55. Read the comment docs.

@cdcabrera cdcabrera changed the title feat(config): sw-1692 add rhel for x86 els payg feat(config): sw-1889 add rhel for x86 els payg Oct 31, 2023
@cdcabrera cdcabrera force-pushed the sw-1889 branch 3 times, most recently from 287d8af to 6ce3862 Compare November 1, 2023 18:32
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Nov 1, 2023
* inventoryCardHelpers, allow callbacks, info tooltips
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Nov 1, 2023
* locales, vcpus, fix product subtitles
* rhsmConstants, vcpus metric
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Nov 1, 2023
* config, use vcpu metric, base off rhosak
* locale, adjust rhel desc, subtitle for on-demand
* services, generic mock response, allow vcpus
@cdcabrera cdcabrera marked this pull request as ready for review November 1, 2023 19:14
src/config/product.rhelElsPayg.js Outdated Show resolved Hide resolved
src/config/product.rhelElsPayg.js Outdated Show resolved Hide resolved
src/config/product.rhelElsPayg.js Outdated Show resolved Hide resolved
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Nov 2, 2023
* inventoryCardHelpers, allow callbacks, info tooltips
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Nov 2, 2023
* locales, vcpus, fix product subtitles
* rhsmConstants, vcpus metric
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Nov 2, 2023
* config, use vcpu metric, base off rhosak
* locale, adjust rhel desc, subtitle for on-demand
* services, generic mock response, allow vcpus
* inventoryCardHelpers, allow callbacks, info tooltips
* locales, vcpus, fix product subtitles
* rhsmConstants, vcpus metric
* config, use vcpu metric, base off rhosak
* locale, adjust rhel desc, subtitle for on-demand
* services, generic mock response, allow vcpus
@cdcabrera cdcabrera merged commit d46fab0 into RedHatInsights:main Nov 2, 2023
5 of 7 checks passed
cdcabrera added a commit that referenced this pull request Nov 2, 2023
* inventoryCardHelpers, allow callbacks, info tooltips
cdcabrera added a commit that referenced this pull request Nov 2, 2023
* locales, vcpus, fix product subtitles
* rhsmConstants, vcpus metric
cdcabrera added a commit that referenced this pull request Nov 7, 2023
* inventoryCardHelpers, allow callbacks, info tooltips
cdcabrera added a commit that referenced this pull request Nov 7, 2023
* locales, vcpus, fix product subtitles
* rhsmConstants, vcpus metric
cdcabrera added a commit that referenced this pull request Nov 7, 2023
* config, use vcpu metric, base off rhosak
* locale, adjust rhel desc, subtitle for on-demand
* services, generic mock response, allow vcpus
cdcabrera added a commit that referenced this pull request Nov 7, 2023
* inventoryCardHelpers, allow callbacks, info tooltips
cdcabrera added a commit that referenced this pull request Nov 7, 2023
* locales, vcpus, fix product subtitles
* rhsmConstants, vcpus metric
cdcabrera added a commit that referenced this pull request Nov 7, 2023
* config, use vcpu metric, base off rhosak
* locale, adjust rhel desc, subtitle for on-demand
* services, generic mock response, allow vcpus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202312 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants