Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(config): sw-1987 testing, numeric inventory cells #1259

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jan 22, 2024

What's included

  • refactor(config): sw-1987 testing, numeric inventory cells

Notes

  • expose all inventory numeric cell values under a data-value and associated data-test=[instances|subscriptions]-cell-[field name] attributes on a surrounding <span /> tag
  • LIMITATIONS
    • currently we do not include the row count anywhere in the display
    • if a value is undefined it will display as the string undefined... this shouldn't happen, but we planned for it but this is the expected result if it happens

How to test

Local run check

  1. update the NPM packages with $ npm install
  2. $ npm start
  3. open each product view and confirm that data-test and data-value appear on a <span /> tag wrapped around numeric inventory content

Proxy run check

  1. update the NPM packages with $ npm install
  2. make sure Docker is running, plus on network, then
  3. $ npm run start:proxy
  4. open each product view and confirm that data-test and data-value appear on a <span /> tag wrapped around numeric inventory content

Example

Instances inventory cells

<span
    data-test="instances-cell-[field or metric id]"
    data-value="[original value]"
>
    [numeric display string]
</span>

Subscriptions inventory cells

<span
    data-test="subscriptions-cell-[field or metric id]"
    data-value="[original value]"
>
    [numeric display string]
</span>

Updates issue/story

sw-1987

@cdcabrera cdcabrera added the 202404 project phase label Jan 22, 2024
@cdcabrera cdcabrera marked this pull request as ready for review January 22, 2024 22:00
@cdcabrera cdcabrera merged commit 9a3b321 into RedHatInsights:main Jan 23, 2024
4 of 7 checks passed
cdcabrera added a commit that referenced this pull request Jan 31, 2024
* config, apply data attributes for table cells
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202404 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant