Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 of 3, feat(serviceConfig): sw-2024 allow response polling #1272

Merged

Conversation

cdcabrera
Copy link
Member

What's included

  • feat(serviceConfig): sw-2024 allow response polling
  • refactor(serviceConfig): memoize transformers

Notes

  • adds a service configuration poll
  • passive config update until activated

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ npm install
  2. $ npm test
  3. confirm tests come back clean

Check the build

  1. update the NPM packages with $ npm install
  2. $ npm run build
  3. confirm tests come back clean

Example

...

Updates issue/story

sw-2024
related #1269

@cdcabrera cdcabrera added enhancement Addition to an existing feature 202404 project phase labels Feb 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2024

Codecov Report

Merging #1272 (cc0cd3e) into main (c1d4152) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1272      +/-   ##
==========================================
+ Coverage   91.92%   92.02%   +0.09%     
==========================================
  Files         113      113              
  Lines        4299     4351      +52     
  Branches     1818     1834      +16     
==========================================
+ Hits         3952     4004      +52     
  Misses        327      327              
  Partials       20       20              
Files Coverage Δ
src/common/helpers.js 100.00% <100.00%> (ø)
src/services/common/helpers.js 92.50% <100.00%> (ø)
src/services/common/serviceConfig.js 99.21% <100.00%> (+0.51%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1d4152...cc0cd3e. Read the comment docs.

cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Feb 16, 2024
* helpers, memoClone for passed callback parameters
* serviceConfig, callback memoClone, error messaging
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Feb 16, 2024
@cdcabrera cdcabrera force-pushed the 20240216-sw-2024-serviceConfig branch from 565b157 to 7da1360 Compare February 16, 2024 15:56
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Feb 16, 2024
* helpers, memoClone for passed callback parameters
* serviceConfig, callback memoClone, error messaging
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Feb 16, 2024
@cdcabrera cdcabrera force-pushed the 20240216-sw-2024-serviceConfig branch from 9456912 to cc0cd3e Compare February 16, 2024 21:01
@cdcabrera cdcabrera changed the title feat(serviceConfig): sw-2024 allow response polling 1 of 3, feat(serviceConfig): sw-2024 allow response polling Feb 16, 2024
* helpers, memoClone for passed callback parameters
* serviceConfig, callback memoClone, error messaging
@cdcabrera cdcabrera force-pushed the 20240216-sw-2024-serviceConfig branch from cc0cd3e to dce14d6 Compare February 19, 2024 18:59
@cdcabrera cdcabrera merged commit 53d2b88 into RedHatInsights:main Feb 19, 2024
5 of 7 checks passed
cdcabrera added a commit that referenced this pull request Feb 19, 2024
* helpers, memoClone for passed callback parameters
* serviceConfig, callback memoClone, error messaging
cdcabrera added a commit that referenced this pull request Feb 27, 2024
* helpers, memoClone for passed callback parameters
* serviceConfig, callback memoClone, error messaging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202404 project phase enhancement Addition to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants