Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): sw-2480 activate rosa instance_id #1314

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(config): sw-2480 activate rosa instance_id

Notes

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ npm install
  2. $ npm test
  3. confirm tests come back clean

Example

...

Updates issue/story

related sw-2480

@cdcabrera cdcabrera added bug Something isn't working 202404 project phase labels Apr 24, 2024
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@2dbcdd2). Click here to learn what that means.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1314   +/-   ##
=======================================
  Coverage        ?   91.90%           
=======================================
  Files           ?      114           
  Lines           ?     4458           
  Branches        ?     1884           
=======================================
  Hits            ?     4097           
  Misses          ?      339           
  Partials        ?       22           
Files Coverage Δ
src/config/product.rhods.js 85.71% <100.00%> (ø)
src/config/product.rhacs.js 86.00% <50.00%> (ø)
src/config/product.rosa.js 80.76% <66.66%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dbcdd2...99193d2. Read the comment docs.

@cdcabrera cdcabrera merged commit fea3bd6 into RedHatInsights:main Apr 24, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202404 project phase bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants