Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWATCH-2729: Change custom export notification's data-test for No button #1353

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

mmusil
Copy link
Contributor

@mmusil mmusil commented Jul 10, 2024

What's included

fix: SWATCH-2729 Change data-test prop for custom export notification's "No" button to be unique.

Notes

  • corrections for qe test environment

How to test

  • In environment
    • attempt to download an export/report from any product
    • navigate away from the swatch ui, this includes all variants, using the left nav or direct navigation
    • wait an average of 5 seconds, variations in this time should still produce similar results
    • navigate back towards the swatch ui, a toast notification should appear with yes/no confirmation buttons
      • Confirm the related qe tests are able to access the new data-test attribute for No

Example

...

Updates issue/story

sw-2729

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.76%. Comparing base (e8e6e81) to head (2544570).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1353   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files         115      115           
  Lines        4554     4554           
  Branches     1923     1923           
=======================================
  Hits         4179     4179           
  Misses        350      350           
  Partials       25       25           
Files Coverage Δ
...rc/components/toolbar/toolbarFieldExportContext.js 94.05% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8e6e81...2544570. Read the comment docs.

@cdcabrera cdcabrera added env:test 202408 project phase labels Jul 10, 2024
@cdcabrera cdcabrera merged commit 18a4b0a into RedHatInsights:main Jul 10, 2024
4 of 7 checks passed
@mmusil mmusil deleted the SWATCH-2729 branch July 11, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202408 project phase env:test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants