refactor: sw-2479 promiseMiddleware, catch rejections #1397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
promise-middleware
for redux to allow "catching" promise rejections. by doing this we still allow the errors and axios transformations to make their way into the state layer, and we avoid broadcasting it beyondpromise middleware
. we may have to reevaluate if we decide to use some level of promises with notificationsHow to test
Coverage and basic unit test check
$ npm install
$ npm test
Local run check
$ npm install
$ npm start
403
error locally./src/services/rhsm/rhsmServices.js
by adding this code@apiMock {Force} 403
to line1236
opt in
display[uncaught in promise]
error no longer displaysCheck the build
$ npm install
$ npm run build
Example
...
Updates issue/story
sw-2479