Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): sw-2932 ansible, on-demand graph displays #1419

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(config): sw-2932 ansible, on-demand graph displays

Notes

  • adds an ansible path alias
  • adds the on-demand display for ansible, this comes with copy alterations
    • the original mock displayed a single line with a label that replicated the card name of the graph... both of these things have changed
      • legend copy now reflects closer to the generic ROSA display
      • graph lines have been converted to area charts, same as, ROSA

How to test

Local run check

  1. update the NPM packages with $ npm install
  2. $ npm start
  3. navigate towards ansible
    • confirm the display appears like the below example (there may be minor differences between local and staging due to mock data)

Example

Screenshot 2024-09-19 at 15-06-30 Standalone Curiosity

Updates issue/story

related to sw-2822
sw-2932

@cdcabrera cdcabrera added bug Something isn't working 202412 project phase labels Sep 19, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.40%. Comparing base (cc25061) to head (602c9c0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1419   +/-   ##
=======================================
  Coverage   91.40%   91.40%           
=======================================
  Files         116      116           
  Lines        4608     4608           
  Branches     1966     1966           
=======================================
  Hits         4212     4212           
  Misses        367      367           
  Partials       29       29           
Files with missing lines Coverage Δ
src/config/product.ansible.js 80.39% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc25061...602c9c0. Read the comment docs.

@cdcabrera cdcabrera merged commit 599e445 into RedHatInsights:main Sep 19, 2024
6 of 8 checks passed
@cdcabrera cdcabrera mentioned this pull request Sep 20, 2024
@cdcabrera cdcabrera mentioned this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202412 project phase bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants