Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): sw-2953 ansible missing graph tooltips #1423

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Sep 24, 2024

What's included

  • fix(locale): sw-2953 ansible missing graph tooltips

Notes

  • adds in a missing graph legend tooltip for managed nodes
  • corrects a graph legend tooltip for infrastructure hours

How to test

Local run check

  1. update the NPM packages with $ npm install
  2. $ npm start
  3. hover over the graph legend and confirm
    • Managed nodes tooltip for on-demand now displays as expected
    • Infrastructure hours tooltip for on-demand no longer uses ROSA language for "control plane"

Example

Screenshot 2024-09-24 at 11 00 52 AM (2)

Screenshot 2024-09-24 at 11 01 17 AM (2)

Updates issue/story

sw-2953

@cdcabrera cdcabrera added bug Something isn't working 202412 project phase labels Sep 24, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.40%. Comparing base (615d52a) to head (a4e0ffd).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1423   +/-   ##
=======================================
  Coverage   91.40%   91.40%           
=======================================
  Files         116      116           
  Lines        4608     4608           
  Branches     1966     1966           
=======================================
  Hits         4212     4212           
  Misses        367      367           
  Partials       29       29           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 615d52a...a4e0ffd. Read the comment docs.

@cdcabrera cdcabrera merged commit 46f319e into RedHatInsights:main Sep 24, 2024
9 of 11 checks passed
@cdcabrera cdcabrera mentioned this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202412 project phase bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants