Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rhelServices, redux): issues/17 rhsm api, and mock #27

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

cdcabrera
Copy link
Member

What's included

  • feat(rhelServices, redux): issues/17 rhsm api
    • build, dotenv rhsm api endpoint
    • build, scripts and temporary rhsm swagger for local doc run
    • rhelServices, implement rhsm endpoint, mock added
    • redux, action, reducer, types
    • unit tests, snapshots

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test

Interactive unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test:dev

Example

...

Updates issue/story

Updates #17

* build, dotenv rhsm api endpoint
* build, scripts and temporary rhsm swagger for local doc run
* rhelServices, implement rhsm endpoint, mock added
* redux, action, reducer, types
* unit tests, snapshots
@codecov-io
Copy link

Codecov Report

Merging #27 into master will increase coverage by 0.55%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   80.28%   80.84%   +0.55%     
==========================================
  Files          21       21              
  Lines         208      214       +6     
  Branches       45       46       +1     
==========================================
+ Hits          167      173       +6     
  Misses         31       31              
  Partials       10       10
Impacted Files Coverage Δ
src/redux/reducers/rhelGraphReducer.js 100% <ø> (ø) ⬆️
src/redux/actions/rhelActions.js 100% <ø> (ø) ⬆️
src/services/config.js 42.85% <100%> (ø) ⬆️
src/services/rhelServices.js 100% <100%> (ø) ⬆️
src/types/rhelApiTypes.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4949cd0...293081c. Read the comment docs.

@cdcabrera cdcabrera merged commit 4641c5b into RedHatInsights:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants