Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): issues/274 update proxy docker port mapping #276

Merged
merged 1 commit into from
May 7, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented May 7, 2020

What's included

  • fix(build): issues/274 update proxy docker port mapping
    • build, API updates, proxy run origin header needs port 443
    • docs, contributing reference added for port 443 troubleshooting

Notes

  • This relates to recent permissions changes on the RHSM API.
    • We can no longer utilize 1337 the origin header requires being set as 443
  • This may cause issues if external teams require access to the API and are attempting to develop on the local proxy. ReadMe should be updated to highlight this.

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm you can interact with the Subs Watch interface, graph should be visible, opt-in should function, etc...

Example

...

Updates issue/story

closes #274

…ts#276)

* build, API updates, proxy run origin header needs port 443
* docs, contributing reference added for port 443 troubleshooting
@codecov-io
Copy link

Codecov Report

Merging #276 into ci will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #276   +/-   ##
=======================================
  Coverage   92.36%   92.36%           
=======================================
  Files          47       47           
  Lines        1022     1022           
  Branches      240      240           
=======================================
  Hits          944      944           
  Misses         72       72           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 709060d...cafbd4d. Read the comment docs.

@cdcabrera cdcabrera merged commit 2ee78de into RedHatInsights:ci May 7, 2020
cdcabrera added a commit that referenced this pull request May 8, 2020
* build, API updates, proxy run origin header needs port 443
* docs, contributing reference added for port 443 troubleshooting
cdcabrera added a commit that referenced this pull request May 8, 2020
* build, API updates, proxy run origin header needs port 443
* docs, contributing reference added for port 443 troubleshooting
@cdcabrera cdcabrera mentioned this pull request May 19, 2020
cdcabrera added a commit that referenced this pull request May 19, 2020
* build, API updates, proxy run origin header needs port 443
* docs, contributing reference added for port 443 troubleshooting
@cdcabrera cdcabrera mentioned this pull request May 20, 2020
cdcabrera added a commit that referenced this pull request May 20, 2020
* build, API updates, proxy run origin header needs port 443
* docs, contributing reference added for port 443 troubleshooting
cdcabrera added a commit that referenced this pull request May 20, 2020
* build, API updates, proxy run origin header needs port 443
* docs, contributing reference added for port 443 troubleshooting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants