fix(graphCardHelpers): issues/180 tooltip show all data facets #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
May 12, 2020
…ights#282) * graphCardHelpers, update tooltip to display all data facets * graphCardSelectors, pass has_data and has_infinite to graphCard * i18n, strings updated
Codecov Report
@@ Coverage Diff @@
## ci #282 +/- ##
==========================================
+ Coverage 92.42% 92.44% +0.01%
==========================================
Files 47 47
Lines 1030 1032 +2
Branches 244 245 +1
==========================================
+ Hits 952 954 +2
Misses 72 72
Partials 6 6
Continue to review full report at Codecov.
|
cdcabrera
changed the title
…ights#282) * graphCardHelpers, update tooltip to display all data facets * graphCardSelectors, pass has_data and has_infinite to graphCard * i18n, strings updated
Merged
cdcabrera
added a commit
that referenced
this pull request
May 19, 2020
* graphCardHelpers, update tooltip to display all data facets * graphCardSelectors, pass has_data and has_infinite to graphCard * i18n, strings updated
Merged
cdcabrera
added a commit
that referenced
this pull request
May 20, 2020
* graphCardHelpers, update tooltip to display all data facets * graphCardSelectors, pass has_data and has_infinite to graphCard * i18n, strings updated
cdcabrera
added a commit
that referenced
this pull request
May 20, 2020
* graphCardHelpers, update tooltip to display all data facets * graphCardSelectors, pass has_data and has_infinite to graphCard * i18n, strings updated
kahowell
added a commit
to RedHatInsights/rhsm-subscriptions
that referenced
this pull request
Apr 21, 2021
Tiny follow-up to #415 Without this change, days without any recorded usage show up in the tooltip as "no data", rather than the cumulative total. See RedHatInsights/curiosity-frontend#282 for explanation of GUI logic wrt `has_data`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
19 scenarios tested. Logic for displaying
no dataandunlimitedvs data. Unit test snapshots are in place and can be confirmed here,curiosity-frontend/src/components/graphCard/__tests__/__snapshots__/graphCardHelpers.test.js.snap
Lines 21 to 262 in b8de0bd
nullandhas data = undefinedwill display0per each facetnullandhas data = falsewill displayno dataper each facetnullandhas data = truewill display0per each facet>= 0andhas data = undefinedwill display said value per each facet>= 0andhas data = falsewill displayno dataper each facet>= 0andhas data = truewill display said value per each facetnullandhas infinite = undefinedwill displayno datanullandhas infinite = falsewill displayno datanullandhas infinite = truewill displayunlimited>= 0andhas infinite = undefinedwill display said value>= 0andhas infinite = falsewill display said value>= 0andhas infinite = truewill displayunlimitedmissing datawill result in a singularNo datatooltip displayHow to test
Local run check
$ yarn$ yarn startExample
Updates issue/story
#180