Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): add general code tests, lost console methods #351

Merged
merged 1 commit into from
Jul 25, 2020

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(testing): add general code tests, lost console methods

Notes

  • Behind the scenes, no visual aspect beyond CI logging
  • This test opens up applying general global code checks
  • We've relaxed the linter checks around console.log. This re-applies a global level check for console methods.

How to test

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. Dist level tests should complete

Example

...

Updates issue/story

Ongoing

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2020

Codecov Report

Merging #351 into ci will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #351   +/-   ##
=======================================
  Coverage   92.40%   92.40%           
=======================================
  Files          61       61           
  Lines        1475     1475           
  Branches      349      349           
=======================================
  Hits         1363     1363           
  Misses         98       98           
  Partials       14       14           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abd4302...e061299. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants