Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): issues/502 add recommendations link #508

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

cdcabrera
Copy link
Member

What's included

Notes

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. log in with an account that has mismatched Cloud Meter data, expecting the banner to be displayed
  5. click on the link and confirm it navigates towards https://access.redhat.com/subscription-watch-accuracy

Example

Screen Shot 2020-11-16 at 6 21 26 PM (2)

Updates issue/story

#502

@cdcabrera cdcabrera added the blocked Prevented from continuing label Nov 17, 2020
@cdcabrera
Copy link
Member Author

As of 20201116 temporarily applying the blocked label to this since the link currently doesn't go anywhere.

@codecov-io
Copy link

codecov-io commented Nov 17, 2020

Codecov Report

Merging #508 (6cad86d) into qa (e2b0a9c) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##               qa     #508      +/-   ##
==========================================
- Coverage   93.47%   93.44%   -0.04%     
==========================================
  Files          74       74              
  Lines        1963     2379     +416     
  Branches      496      813     +317     
==========================================
+ Hits         1835     2223     +388     
- Misses        110      138      +28     
  Partials       18       18              
Impacted Files Coverage Δ
src/components/router/redirect.js 65.00% <0.00%> (-5.59%) ⬇️
src/components/router/routerHelpers.js 91.42% <0.00%> (-5.45%) ⬇️
src/redux/selectors/inventoryListSelectors.js 97.56% <0.00%> (-2.44%) ⬇️
src/components/inventoryList/inventoryList.js 90.90% <0.00%> (-2.43%) ⬇️
src/services/platformServices.js 97.67% <0.00%> (-2.33%) ⬇️
src/components/rhelView/rhelView.js 90.69% <0.00%> (-1.90%) ⬇️
src/components/openshiftView/openshiftView.js 93.93% <0.00%> (-1.90%) ⬇️
src/redux/selectors/graphCardSelectors.js 98.21% <0.00%> (-1.79%) ⬇️
src/components/graphCard/graphCardHelpers.js 98.61% <0.00%> (-1.39%) ⬇️
src/components/c3GraphCard/c3GraphCardHelpers.js 75.58% <0.00%> (-1.35%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b0a9c...6cad86d. Read the comment docs.

bclarhk
bclarhk previously approved these changes Nov 17, 2020
Copy link

@bclarhk bclarhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll likely edit the text once we have a writer with a working computer. ;-)

@rblackbu
Copy link

Copy update proposal prior to activating the link.

Title: Cloud provider mismatch
Body: There may be inconsistencies between data in the graph and your inventory display. The issue is currently being resolved.

@cdcabrera
Copy link
Member Author

cdcabrera commented Dec 2, 2020

As of 20201202 we were expecting the copy and link to be active, since the link is not we'll go ahead and direct this PR towards the CI branch

@cdcabrera cdcabrera changed the base branch from qa to ci December 2, 2020 18:34
@cdcabrera cdcabrera dismissed bclarhk’s stale review December 2, 2020 18:34

The base branch was changed.

@cdcabrera
Copy link
Member Author

Per @jlprevatt updates to copy requested

Original:

There may be inconsistencies between data in the graph and your inventory display. The issue is currently being resolved.

Change 1

"There may be" > "There might be" (Reason: "may" can mean "can" or "might" and the meaning can be misunderstood by ESL folks. Always use the more precise word, "can" or "might")

Change 2

It would be better to more closely match the terms used in the GUI/doc for the graph and table. (The doc uses "usage and utilization graph" and shortens to "the graph" so I don't mind "graph" so much. But instead of "inventory" we should be using "current systems table.") So "...between the data in the graph and the current systems table."

Additional comment

I had it pounded into my head to never promise the user a fix in writing. But if [the team approved this already], then I'll let it be.

@cdcabrera cdcabrera changed the base branch from ci to qa December 11, 2020 03:48
@cdcabrera cdcabrera removed the blocked Prevented from continuing label Dec 11, 2020
@cdcabrera
Copy link
Member Author

@ntkathole we're moving forward with getting this into QA in prep for an incremental push to prod-beta

@cdcabrera cdcabrera merged commit 6ac6433 into RedHatInsights:qa Dec 11, 2020
@ntkathole
Copy link
Member

Per @jlprevatt updates to copy requested

Original:

There may be inconsistencies between data in the graph and your inventory display. The issue is currently being resolved.

Change 1

"There may be" > "There might be" (Reason: "may" can mean "can" or "might" and the meaning can be misunderstood by ESL folks. Always use the more precise word, "can" or "might")

@jlprevatt this change should go into the document as well. Currently it say "There may be inconsistencies between data in the graph and your inventory display".

@ntkathole
Copy link
Member

@cdcabrera

  • There is typo in message "recommmend"

  • We are seeing only "View recommended actions to take in order to improve Subscription Watch reporting." message. The other message is not visible.
    "There might be inconsistencies between data in the graph and your current systems table. The issue is currently being resolved."
    can you please confirm if following banner is expected ?

Screenshot from 2020-12-11 14-05-15

@jlprevatt
Copy link
Collaborator

@ntkathole Regarding your direct comment to me above, I was initially confused and thought you meant the product doc, but I think you mean the draft of the customer portal article. Yes, if the customer portal article directly quotes the on-screen messaging, the exact text of the message should appear there.

cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Dec 12, 2020
@cdcabrera
Copy link
Member Author

Looks like we missed your ask @ntkathole ...

can you please confirm if following banner is expected ?

That is correct. The more verbose banner is the fallback for when the message has no link available. Now that the link is active this is expected

Screen Shot 2020-12-12 at 2 23 40 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants