Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphCard): ent-3507 expose start, end for date query #589

Merged
merged 2 commits into from
Feb 24, 2021

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(graphCard): ent-3507 expose start, end for date query
    • graphCard, expose start, end query to allow alt granularity dropdown
    • openshiftView, productView, Rhel, Satellite, props updates
    • viewReducer, queryTypes, graphCardSelectors, expose start, end query
  • feat(toolbarFieldRangedMonthly): ent-3507 select month range
    • dateHelpers, generate a listing of month, date objects
    • select, maxHeight pf prop
    • toolbarFieldRangedMonthly, prior months with date ranges

Notes

  • Require setting the granularity date range for graphCard. The new flex graph display monthly ranges for OpenShift are based on daily granularity but are a range for specific months. Since we plan on reusing the graph component we now pass start/beginning and end/ending query params. Relocates the granularity "infer" in the related granularity dropdown component.
  • Creates the new dropdown/select for monthly ranges, see below examples. Based on UX/design we place the prior year next to the related months.
    • Future updates include turning this dropdown/select into a divided select based on PF React Select
    • This is a behind the scenes add, currently this component is NOT linked from anywhere

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back without error

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm granularity can still be updated across all products, RHEL, Satellite, and existing OpenShift

Example

Screen Shot 2021-02-24 at 12 47 46 AM
Screen Shot 2021-02-24 at 12 47 55 AM

Updates issue/story

ent-3507
ent-3324

@cdcabrera cdcabrera added story New feature, or process work 202104 project phase labels Feb 24, 2021
src/common/dateHelpers.js Show resolved Hide resolved
src/common/dateHelpers.js Show resolved Hide resolved
src/common/dateHelpers.js Outdated Show resolved Hide resolved
src/components/openshiftView/openshiftView.js Show resolved Hide resolved
src/components/productView/productViewRhel.js Show resolved Hide resolved
…ghts#589)

* graphCard, expose start, end query to allow alt granularity dropdown
* openshiftView, productView, Rhel, Satellite, props updates
* viewReducer, queryTypes, graphCardSelectors, expose start, end query
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Feb 24, 2021
…nsights#589)

* dateHelpers, generate a listing of month, date objects
* select, maxHeight pf prop
* toolbarFieldRangedMonthly, prior months with date ranges
@codecov-io
Copy link

Codecov Report

Merging #589 (aeb1cd8) into ci (6a7b074) will decrease coverage by 0.05%.
The diff coverage is 98.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #589      +/-   ##
==========================================
- Coverage   94.10%   94.04%   -0.06%     
==========================================
  Files          85       86       +1     
  Lines        2069     2537     +468     
  Branches      523      864     +341     
==========================================
+ Hits         1947     2386     +439     
- Misses        102      131      +29     
  Partials       20       20              
Impacted Files Coverage Δ
src/components/openshiftView/openshiftView.js 89.79% <ø> (-1.39%) ⬇️
src/components/productView/productView.js 100.00% <ø> (ø)
src/components/productView/productViewRhel.js 85.71% <ø> (-1.79%) ⬇️
src/components/productView/productViewSatellite.js 85.71% <ø> (-1.79%) ⬇️
src/redux/selectors/graphCardSelectors.js 98.14% <ø> (-1.86%) ⬇️
src/redux/types/queryTypes.js 100.00% <ø> (ø)
...rc/components/toolbar/toolbarFieldRangedMonthly.js 91.66% <91.66%> (ø)
src/common/dateHelpers.js 100.00% <100.00%> (ø)
src/components/form/select.js 100.00% <100.00%> (ø)
src/components/graphCard/graphCard.js 90.38% <100.00%> (+1.74%) ⬆️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a7b074...aeb1cd8. Read the comment docs.

@cdcabrera
Copy link
Member Author

We have a test branch for handling the toISOString conversions inside dateHelpers. This update still seems viable, but we'll know more once we start using the new toolbarFieldRangedMonthly. We'll revisit it, https://github.com/cdcabrera/curiosity-frontend/tree/20210224-dev-isostring-date-ent-3507

…nsights#589)

* dateHelpers, generate a listing of month, date objects
* select, maxHeight pf prop
* toolbarFieldRangedMonthly, prior months with date ranges
@cdcabrera cdcabrera merged commit 90b67c8 into RedHatInsights:ci Feb 24, 2021
cdcabrera added a commit that referenced this pull request Feb 24, 2021
* graphCard, expose start, end query to allow alt granularity dropdown
* openshiftView, productView, Rhel, Satellite, props updates
* viewReducer, queryTypes, graphCardSelectors, expose start, end query
cdcabrera added a commit that referenced this pull request Mar 5, 2021
* graphCard, expose start, end query to allow alt granularity dropdown
* openshiftView, productView, Rhel, Satellite, props updates
* viewReducer, queryTypes, graphCardSelectors, expose start, end query
cdcabrera added a commit that referenced this pull request Mar 5, 2021
* dateHelpers, generate a listing of month, date objects
* select, maxHeight pf prop
* toolbarFieldRangedMonthly, prior months with date ranges
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 24, 2021
…ghts#589)

* graphCard, expose start, end query to allow alt granularity dropdown
* openshiftView, productView, Rhel, Satellite, props updates
* viewReducer, queryTypes, graphCardSelectors, expose start, end query
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 24, 2021
…nsights#589)

* dateHelpers, generate a listing of month, date objects
* select, maxHeight pf prop
* toolbarFieldRangedMonthly, prior months with date ranges
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 25, 2021
…ghts#589)

* graphCard, expose start, end query to allow alt granularity dropdown
* openshiftView, productView, Rhel, Satellite, props updates
* viewReducer, queryTypes, graphCardSelectors, expose start, end query
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 25, 2021
…nsights#589)

* dateHelpers, generate a listing of month, date objects
* select, maxHeight pf prop
* toolbarFieldRangedMonthly, prior months with date ranges
cdcabrera added a commit that referenced this pull request Mar 25, 2021
* graphCard, expose start, end query to allow alt granularity dropdown
* openshiftView, productView, Rhel, Satellite, props updates
* viewReducer, queryTypes, graphCardSelectors, expose start, end query
cdcabrera added a commit that referenced this pull request Mar 25, 2021
* dateHelpers, generate a listing of month, date objects
* select, maxHeight pf prop
* toolbarFieldRangedMonthly, prior months with date ranges
cdcabrera added a commit that referenced this pull request Apr 13, 2021
* graphCard, expose start, end query to allow alt granularity dropdown
* openshiftView, productView, Rhel, Satellite, props updates
* viewReducer, queryTypes, graphCardSelectors, expose start, end query
cdcabrera added a commit that referenced this pull request Apr 13, 2021
* dateHelpers, generate a listing of month, date objects
* select, maxHeight pf prop
* toolbarFieldRangedMonthly, prior months with date ranges
cdcabrera added a commit that referenced this pull request Apr 13, 2021
* graphCard, expose start, end query to allow alt granularity dropdown
* openshiftView, productView, Rhel, Satellite, props updates
* viewReducer, queryTypes, graphCardSelectors, expose start, end query
cdcabrera added a commit that referenced this pull request Apr 13, 2021
* dateHelpers, generate a listing of month, date objects
* select, maxHeight pf prop
* toolbarFieldRangedMonthly, prior months with date ranges
cdcabrera added a commit that referenced this pull request Apr 20, 2021
* graphCard, expose start, end query to allow alt granularity dropdown
* openshiftView, productView, Rhel, Satellite, props updates
* viewReducer, queryTypes, graphCardSelectors, expose start, end query
cdcabrera added a commit that referenced this pull request Apr 20, 2021
* dateHelpers, generate a listing of month, date objects
* select, maxHeight pf prop
* toolbarFieldRangedMonthly, prior months with date ranges
cdcabrera added a commit that referenced this pull request Apr 26, 2021
* graphCard, expose start, end query to allow alt granularity dropdown
* openshiftView, productView, Rhel, Satellite, props updates
* viewReducer, queryTypes, graphCardSelectors, expose start, end query
cdcabrera added a commit that referenced this pull request Apr 26, 2021
* dateHelpers, generate a listing of month, date objects
* select, maxHeight pf prop
* toolbarFieldRangedMonthly, prior months with date ranges
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202104 project phase story New feature, or process work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants