Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageColumns): smaller screen size column widths #617

Merged
merged 2 commits into from
Apr 15, 2021

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(pageColumns): smaller screen size column widths
  • fix(actionRecordMiddleware): expand sanitizeData

Notes

  • Minor styling adjustment for the columns OpenShift display at smaller screen sizes

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. navigation towards [env path]/subscriptions/openshift-container, scale the browser to a smaller width, confirm the columns appear like the below screenshot

Example

after

Screen Shot 2021-04-15 at 11 14 27 AM

before

Screenshot from 2021-04-14 15-26-41

Updates issue/story

Ongoing

@codecov-io
Copy link

Codecov Report

Merging #617 (0276a96) into ci (fe46047) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #617   +/-   ##
=======================================
  Coverage   93.83%   93.83%           
=======================================
  Files          86       86           
  Lines        2597     2597           
  Branches      907      907           
=======================================
  Hits         2437     2437           
  Misses        137      137           
  Partials       23       23           
Impacted Files Coverage Δ
src/components/pageLayout/pageColumns.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe46047...0276a96. Read the comment docs.

@cdcabrera cdcabrera merged commit 21388b3 into RedHatInsights:ci Apr 15, 2021
@cdcabrera cdcabrera added 202104 project phase bug Something isn't working labels Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202104 project phase bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants