Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(dev,proxy): ent-3643 activate chrome2 for local run #757

Merged
merged 3 commits into from
Aug 4, 2021

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Aug 2, 2021

What's included

  • build(dev,proxy): ent-3643 activate chrome2 for local run

Notes

  • activates chrome2 for local run, dependent on [ci-beta] Enable chrome2 for subscriptions cloud-services-config#841
  • Setting the default branches for proxy and local development towards ci-beta. Originally we had them set towards environments where the Curiosity Chrome 2 implementation hasn't happened yet. These can be altered at any future point.

How to test

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. confirm Subscriptions and product facets display and function

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm Subscriptions and product facets display and function

Example

...

Updates issue/story

ent-3643
#756
#753

@cdcabrera cdcabrera added story New feature, or process work tech debt We've ignored it this long... 202108 project phase labels Aug 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2021

Codecov Report

Merging #757 (916f321) into ci (d71a14f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #757   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files         101      101           
  Lines        2823     2823           
  Branches     1024     1024           
=======================================
  Hits         2688     2688           
  Misses        128      128           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d71a14f...916f321. Read the comment docs.

* build, travis config passed to custom_release
* docs, release process description expanded
…tion

* build, clean up unused dotenv params
* build, roll back branch for local run in envs Curiosity actually uses Chrome 2
@cdcabrera cdcabrera merged commit 8e4b28d into RedHatInsights:ci Aug 4, 2021
cdcabrera added a commit that referenced this pull request Aug 4, 2021
* build, custom release, unused params, dev branches
* docs, release process expanded
cdcabrera added a commit that referenced this pull request Aug 5, 2021
* build, custom release, unused params, dev branches
* docs, release process expanded
cdcabrera added a commit that referenced this pull request Aug 9, 2021
* build, custom release, unused params, dev branches
* docs, release process expanded
cdcabrera added a commit that referenced this pull request Aug 9, 2021
* build, custom release, unused params, dev branches
* docs, release process expanded
cdcabrera added a commit that referenced this pull request Aug 10, 2021
* build, custom release, unused params, dev branches
* docs, release process expanded
cdcabrera added a commit that referenced this pull request Aug 10, 2021
* build, custom release, unused params, dev branches
* docs, release process expanded
cdcabrera added a commit that referenced this pull request Aug 10, 2021
* build, custom release, unused params, dev branches
* docs, release process expanded
cdcabrera added a commit that referenced this pull request Aug 10, 2021
* build, custom release, unused params, dev branches
* docs, release process expanded
cdcabrera added a commit that referenced this pull request Aug 17, 2021
* build, custom release, unused params, dev branches
* docs, release process expanded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202108 project phase story New feature, or process work tech debt We've ignored it this long...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants