Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(dev,proxy): ent-3643 eslint webpack plugin #761

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Aug 6, 2021

What's included

  • build(dev,proxy): ent-3643 eslint webpack plugin

Notes

  • dev workflow

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back without error

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. confirm the interface starts and confirm the default local strings display

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm the interface starts

Example

...

Updates issue/story

ent-3643
ent-4230

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2021

Codecov Report

Merging #761 (288e04a) into ci (82ddbca) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #761   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files         101      101           
  Lines        2823     2823           
  Branches     1024     1024           
=======================================
  Hits         2688     2688           
  Misses        128      128           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82ddbca...288e04a. Read the comment docs.

@cdcabrera cdcabrera marked this pull request as ready for review August 20, 2021 20:37
@cdcabrera cdcabrera changed the title WIP build(dev,proxy,prod): ent-3643 eslint webpack plugin build(dev,proxy,prod): ent-3643 eslint webpack plugin Aug 20, 2021
@cdcabrera cdcabrera changed the title build(dev,proxy,prod): ent-3643 eslint webpack plugin build(dev,proxy): ent-3643 eslint webpack plugin Aug 20, 2021
@cdcabrera cdcabrera merged commit 8d91082 into RedHatInsights:ci Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202112 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants