Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): npm updates #767

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Aug 18, 2021

What's included

  • fix(build): npm updates
    • build, monthly, pf react-core tests updates
    • inventoryList, expandable css, tables in columns

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm completion without errors

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. visual regression confirmation

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. visual regression confirmation

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm completion without errors

Example

...

Updates issue/story

ongoing
ent-4230

* build, monthly, pf react-core tests updates
* inventoryList, expandable css, tables in columns
@cdcabrera cdcabrera added the 202112 project phase label Aug 18, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #767 (4aaacbe) into ci (299e157) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #767   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files         101      101           
  Lines        2823     2823           
  Branches     1024     1024           
=======================================
  Hits         2688     2688           
  Misses        128      128           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 299e157...4aaacbe. Read the comment docs.

@cdcabrera cdcabrera merged commit 923eb56 into RedHatInsights:ci Aug 19, 2021
cdcabrera added a commit that referenced this pull request Sep 15, 2021
* build, monthly, pf react-core tests updates
* inventoryList, expandable css, tables in columns
cdcabrera added a commit that referenced this pull request Sep 22, 2021
* build, monthly, pf react-core tests updates
* inventoryList, expandable css, tables in columns
cdcabrera added a commit that referenced this pull request Nov 30, 2021
* build, monthly, pf react-core tests updates
* inventoryList, expandable css, tables in columns
cdcabrera added a commit that referenced this pull request Dec 6, 2021
* build, monthly, pf react-core tests updates
* inventoryList, expandable css, tables in columns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202112 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants