Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rhsmServices): ent-3352 api response props, mock and tests #786

Merged
merged 1 commit into from
Sep 14, 2021
Merged

fix(rhsmServices): ent-3352 api response props, mock and tests #786

merged 1 commit into from
Sep 14, 2021

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Sep 2, 2021 •
edited
Loading

What's included

  • fix(rhsmServices): ent-3352 api response props, mock and tests
    • inventorySubscriptions, test updates
    • productViewRHEL, OpenShiftContainer, Satellite, initial query, test
    • rhsmServices, types, redux, response constants update

Notes

  • flips the base current subscriptions over to the agreed upon JSON response properties and sort params: next_event_date, next_event_type, and service_level
  • @joeldmyers

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. confirm that the current subscriptions tabs for: RHEL, OpenShift Container, and OpenShift Dedicated loads and
    • also confirm that sorting for RHEL and OpenShift Container works for "Service Level" and "Next renewal" by returning api responses with the correct "sort" parameter

Example

...

Updates issue/story

ent-3352

@cdcabrera cdcabrera added story New feature, or process work 202112 project phase labels Sep 2, 2021
@cdcabrera cdcabrera force-pushed the ent-3352-newapiprops branch 2 times, most recently from 3a65c40 to e2fe86a Compare September 8, 2021 14:23
@cdcabrera
Copy link
Member Author

Relates RedHatInsights/rhsm-subscriptions#571

@cdcabrera cdcabrera marked this pull request as ready for review September 14, 2021 15:21
@cdcabrera
fix(rhsmServices): ent-3352 api response props, mock and tests
d9fa918 
* inventorySubscriptions, test updates
* productViewRHEL, OpenShiftContainer, Satellite, initial query, test
* rhsmServices, types, redux, response constants update
@cdcabrera cdcabrera merged commit fcca73c into RedHatInsights:ci Sep 14, 2021
cdcabrera added a commit that referenced this pull request Sep 15, 2021
@cdcabrera
fix(rhsmServices): ent-3352 api response props, mock and tests (#786)
7c5ab13 
* inventorySubscriptions, test updates
* productViewRHEL, OpenShiftContainer, Satellite, initial query, test
* rhsmServices, types, redux, response constants update
@cdcabrera cdcabrera mentioned this pull request Sep 16, 2021
Merged
cdcabrera added a commit that referenced this pull request Sep 22, 2021
@cdcabrera
fix(rhsmServices): ent-3352 api response props, mock and tests (#786)
d7bcfde 
* inventorySubscriptions, test updates
* productViewRHEL, OpenShiftContainer, Satellite, initial query, test
* rhsmServices, types, redux, response constants update
@cdcabrera cdcabrera mentioned this pull request Nov 29, 2021
Merged
cdcabrera added a commit that referenced this pull request Nov 30, 2021
@cdcabrera
fix(rhsmServices): ent-3352 api response props, mock and tests (#786)
e17a2b7 
* inventorySubscriptions, test updates
* productViewRHEL, OpenShiftContainer, Satellite, initial query, test
* rhsmServices, types, redux, response constants update
@cdcabrera cdcabrera mentioned this pull request Nov 30, 2021
Merged
cdcabrera added a commit that referenced this pull request Dec 6, 2021
@cdcabrera
fix(rhsmServices): ent-3352 api response props, mock and tests (#786)
76a3fc7 
* inventorySubscriptions, test updates
* productViewRHEL, OpenShiftContainer, Satellite, initial query, test
* rhsmServices, types, redux, response constants update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
202112 project phase story New feature, or process work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cdcabrera