Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): npm updates #801

Merged
merged 2 commits into from
Sep 22, 2021
Merged

fix(build): npm updates #801

merged 2 commits into from
Sep 22, 2021

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Sep 20, 2021

What's included

  • fix(build): npm updates
  • fix(build): pf, platform npm updates

Notes

  • pf react-table contains potentially breaking changes. we're keeping it as a separate commit for rollback purposes.
    • initial review appears there may be some issues around the event and collapsible guests' displays (expandable sub tables) firing
    • as of 20210922 we're unable to recreate the awkward table collapse behavior for guests, we've squashed all the pf and platform updates into a single commit. if it becomes an issue we'll roll the commit out

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm the tests pass

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm the product views are behaving as intended

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm the build passes

Example

...

Updates issue/story

Ongoing

@cdcabrera cdcabrera added the 202112 project phase label Sep 20, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #801 (26b9f8c) into ci (956edd1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #801   +/-   ##
=======================================
  Coverage   95.31%   95.31%           
=======================================
  Files         101      101           
  Lines        2839     2839           
  Branches     1034     1034           
=======================================
  Hits         2706     2706           
  Misses        125      125           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 956edd1...26b9f8c. Read the comment docs.

@cdcabrera cdcabrera merged commit 09e558f into RedHatInsights:ci Sep 22, 2021
cdcabrera added a commit that referenced this pull request Sep 22, 2021
cdcabrera added a commit that referenced this pull request Sep 22, 2021
cdcabrera added a commit that referenced this pull request Sep 22, 2021
cdcabrera added a commit that referenced this pull request Nov 30, 2021
cdcabrera added a commit that referenced this pull request Nov 30, 2021
cdcabrera added a commit that referenced this pull request Dec 6, 2021
cdcabrera added a commit that referenced this pull request Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202112 project phase build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants