-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(inventory): ent 4572 class to functions #857
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
force-pushed
the
ent-4572-inventory
branch
from
January 11, 2022 16:13
5984322
to
8820d2d
Compare
cdcabrera
force-pushed
the
ci
branch
3 times, most recently
from
January 13, 2022 22:21
b0665d4
to
021ec0d
Compare
cdcabrera
force-pushed
the
ent-4572-inventory
branch
from
January 14, 2022 16:29
573e713
to
92c8809
Compare
cdcabrera
force-pushed
the
ent-4572-inventory
branch
from
January 18, 2022 20:09
bd2f553
to
e0ab73e
Compare
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jan 18, 2022
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jan 18, 2022
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jan 18, 2022
…nsights#857) * locale, disabled tab string * guestsList, class to func, deprecated guests * guestsListContext, hooks for selectors, action * inventoryCard, class to func * inventoryCardContext, hooks for selectors, action * inventorySubscriptions, class to func, alias inventoryCard * inventorySubscriptionsContext, hooks for selectors, action * productViews, component prop drill, config clean up * productViewContext, activate guests config * useReactRedux, expand base redux hooks * viewReducer, guests query and types * selectors, remove unused instances, subscriptions * rhsmConstants, expand for guests, number_of_guests * rhsmSchemas, guests, subscriptions added * rhsmTransformers, instances number_of_guests added
cdcabrera
force-pushed
the
ent-4572-inventory
branch
from
January 18, 2022 22:00
e0ab73e
to
6d334e4
Compare
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jan 18, 2022
…nsights#857) * locale, disabled tab string * guestsList, class to func, deprecated guests * guestsListContext, hooks for selectors, action * inventoryCard, class to func * inventoryCardContext, hooks for selectors, action * inventorySubscriptions, class to func, alias inventoryCard * inventorySubscriptionsContext, hooks for selectors, action * productViews, component prop drill, config clean up * productViewContext, activate guests config * useReactRedux, expand base redux hooks * viewReducer, guests query and types * selectors, remove unused instances, subscriptions * rhsmConstants, expand for guests, number_of_guests * rhsmSchemas, guests, subscriptions added * rhsmTransformers, instances number_of_guests added
cdcabrera
force-pushed
the
ent-4572-inventory
branch
2 times, most recently
from
January 19, 2022 18:08
6b6c8b4
to
718788c
Compare
Codecov Report
@@ Coverage Diff @@
## ci #857 +/- ##
==========================================
- Coverage 94.05% 93.88% -0.18%
==========================================
Files 123 125 +2
Lines 3548 3661 +113
Branches 1377 1433 +56
==========================================
+ Hits 3337 3437 +100
- Misses 194 204 +10
- Partials 17 20 +3
Continue to review full report at Codecov.
|
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jan 21, 2022
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jan 21, 2022
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jan 21, 2022
…nsights#857) * locale, disabled tab string * guestsList, class to func, deprecated guests * guestsListContext, hooks for selectors, action * inventoryCard, class to func * inventoryCardContext, hooks for selectors, action * inventorySubscriptions, class to func, alias inventoryCard * inventorySubscriptionsContext, hooks for selectors, action * productViews, component prop drill, config clean up * productViewContext, activate guests config * useReactRedux, expand base redux hooks * viewReducer, guests query and types * selectors, remove unused instances, subscriptions * rhsmConstants, expand for guests, number_of_guests * rhsmSchemas, guests, subscriptions added * rhsmTransformers, instances number_of_guests added
cdcabrera
force-pushed
the
ent-4572-inventory
branch
2 times, most recently
from
January 21, 2022 19:23
42dc288
to
a85e94e
Compare
cdcabrera
changed the title
WIP refactor(inventory): ent 4572 class to functions
refactor(inventory): ent 4572 class to functions
Jan 21, 2022
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jan 21, 2022
…nsights#857) * locale, disabled tab string * guestsList, class to func, deprecated guests * guestsListContext, hooks for selectors, action * inventoryCard, class to func * inventoryCardContext, hooks for selectors, action * inventorySubscriptions, class to func, alias inventoryCard * inventorySubscriptionsContext, hooks for selectors, action * productViews, component prop drill, config clean up * productViewContext, activate guests config * useReactRedux, expand base redux hooks * viewReducer, guests query and types * selectors, remove unused instances, subscriptions * rhsmConstants, expand for guests, number_of_guests * rhsmSchemas, guests, subscriptions added * rhsmTransformers, instances number_of_guests added
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jan 21, 2022
cdcabrera
force-pushed
the
ent-4572-inventory
branch
from
January 21, 2022 20:34
a85e94e
to
acb1a07
Compare
cdcabrera
commented
Jan 21, 2022
…nsights#857) * locale, disabled tab string * guestsList, class to func, deprecated guests * guestsListContext, hooks for selectors, action * inventoryCard, class to func * inventoryCardContext, hooks for selectors, action * inventorySubscriptions, class to func, alias inventoryCard * inventorySubscriptionsContext, hooks for selectors, action * productViews, component prop drill, config clean up * productViewContext, activate guests config * useReactRedux, expand base redux hooks * viewReducer, guests query and types * selectors, remove unused instances, subscriptions * rhsmConstants, expand for guests, number_of_guests * rhsmSchemas, guests, subscriptions added * rhsmTransformers, instances number_of_guests added
cdcabrera
force-pushed
the
ent-4572-inventory
branch
from
January 25, 2022 18:26
acb1a07
to
8b98961
Compare
cdcabrera
added a commit
that referenced
this pull request
Jan 25, 2022
cdcabrera
added a commit
that referenced
this pull request
Jan 25, 2022
cdcabrera
added a commit
that referenced
this pull request
Jan 25, 2022
* locale, disabled tab string * guestsList, class to func, deprecated guests * guestsListContext, hooks for selectors, action * inventoryCard, class to func * inventoryCardContext, hooks for selectors, action * inventorySubscriptions, class to func, alias inventoryCard * inventorySubscriptionsContext, hooks for selectors, action * productViews, component prop drill, config clean up * productViewContext, activate guests config * useReactRedux, expand base redux hooks * viewReducer, guests query and types * selectors, remove unused instances, subscriptions * rhsmConstants, expand for guests, number_of_guests * rhsmSchemas, guests, subscriptions added * rhsmTransformers, instances number_of_guests added
cdcabrera
added a commit
that referenced
this pull request
Mar 1, 2022
cdcabrera
added a commit
that referenced
this pull request
Mar 1, 2022
cdcabrera
added a commit
that referenced
this pull request
Mar 1, 2022
* locale, disabled tab string * guestsList, class to func, deprecated guests * guestsListContext, hooks for selectors, action * inventoryCard, class to func * inventoryCardContext, hooks for selectors, action * inventorySubscriptions, class to func, alias inventoryCard * inventorySubscriptionsContext, hooks for selectors, action * productViews, component prop drill, config clean up * productViewContext, activate guests config * useReactRedux, expand base redux hooks * viewReducer, guests query and types * selectors, remove unused instances, subscriptions * rhsmConstants, expand for guests, number_of_guests * rhsmSchemas, guests, subscriptions added * rhsmTransformers, instances number_of_guests added
cdcabrera
added a commit
that referenced
this pull request
Mar 1, 2022
Merged
cdcabrera
added a commit
that referenced
this pull request
Mar 8, 2022
cdcabrera
added a commit
that referenced
this pull request
Mar 8, 2022
cdcabrera
added a commit
that referenced
this pull request
Mar 8, 2022
* locale, disabled tab string * guestsList, class to func, deprecated guests * guestsListContext, hooks for selectors, action * inventoryCard, class to func * inventoryCardContext, hooks for selectors, action * inventorySubscriptions, class to func, alias inventoryCard * inventorySubscriptionsContext, hooks for selectors, action * productViews, component prop drill, config clean up * productViewContext, activate guests config * useReactRedux, expand base redux hooks * viewReducer, guests query and types * selectors, remove unused instances, subscriptions * rhsmConstants, expand for guests, number_of_guests * rhsmSchemas, guests, subscriptions added * rhsmTransformers, instances number_of_guests added
cdcabrera
added a commit
that referenced
this pull request
Mar 8, 2022
cdcabrera
added a commit
that referenced
this pull request
Mar 8, 2022
cdcabrera
added a commit
that referenced
this pull request
Mar 8, 2022
cdcabrera
added a commit
that referenced
this pull request
Mar 8, 2022
* locale, disabled tab string * guestsList, class to func, deprecated guests * guestsListContext, hooks for selectors, action * inventoryCard, class to func * inventoryCardContext, hooks for selectors, action * inventorySubscriptions, class to func, alias inventoryCard * inventorySubscriptionsContext, hooks for selectors, action * productViews, component prop drill, config clean up * productViewContext, activate guests config * useReactRedux, expand base redux hooks * viewReducer, guests query and types * selectors, remove unused instances, subscriptions * rhsmConstants, expand for guests, number_of_guests * rhsmSchemas, guests, subscriptions added * rhsmTransformers, instances number_of_guests added
cdcabrera
added a commit
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
deprecated
versions, along with the refactors, since they access thehosts
API endpoint. RHOSAK utilizes the newerinstances
API endpoint ergo it has been updated. The intention is to migrate our other products towards the function components used under RHOSAK when thenumber_of_guests
facet is provided via theinstances
API, ENT-4580key
attributes being used to cause refreshes on inventory. Everything appeared to be refreshing without them during testing, we'll monitor them, if caching issues pop up we'll reimplement them for instances, subscriptions, and the guests displayHow to test
Local run check
$ yarn
$ yarn start
Proxy run check
$ yarn
$ yarn start:proxy
Example
...
Updates issue/story
ent-4572