Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): aggregated dependency checks, updates #903

Merged

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Mar 3, 2022

What's included

  • build(deps): aggregated dependency checks, updates

Notes

  • we'll review adding this to a GitHub action, be a lot nicer than the piecemeal attempts that dependabot performs
    • we're considering running it only 1 to 2 times a month which correlates with our manual NPM updates
    • average time for running this with test checks seems to come out to about 3-5'ish minutes per package. We tested 18 packages that took somewhere around 1.5 hours... that is still a significant decrease from the all day timeframe it normally takes due to day-to-day "obligations"
  • there is still a visual styling element to doing package updates specifically around anything Patternfly and Platform related, so we're going ahead and ignoring them... it's slightly frustrating, but still significantly better than the process is currently.

How to test

Run it!

  1. update the NPM packages with $ yarn
  2. confirm that NPM packages need updating with $ yarn outdated if so...
  3. run $ yarn build:deps
  4. and wait for the process to complete. Depending on how many packages need updating it could take a bit, we averaged around 1.5 hours for about 17 - 18ish packages

Example

...

Updates issue/story

ongoing

@cdcabrera cdcabrera added build 202204 project phase labels Mar 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #903 (bf632a6) into ci (346c179) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #903   +/-   ##
=======================================
  Coverage   94.07%   94.07%           
=======================================
  Files         126      126           
  Lines        3694     3694           
  Branches     1445     1445           
=======================================
  Hits         3475     3475           
  Misses        201      201           
  Partials       18       18           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 346c179...bf632a6. Read the comment docs.

@cdcabrera cdcabrera changed the base branch from ci to main March 3, 2022 16:02
@cdcabrera cdcabrera force-pushed the 20220302-build-dependecy-check branch from bf632a6 to ca51037 Compare March 3, 2022 16:09
@cdcabrera cdcabrera changed the base branch from main to ci March 3, 2022 16:09
@cdcabrera cdcabrera merged commit e64dca4 into RedHatInsights:ci Mar 3, 2022
@cdcabrera cdcabrera mentioned this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202204 project phase build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants