Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rhosak): ent-4689 (sw-93) billing provider, remove none option #951

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jun 24, 2022

What's included

  • fix(rhosak): ent-4689 remove none option fix(rhosak): sw-93 billing provider, remove none option

Notes

  • removes the none option, behavior for fix(rhosak): ent-4689 none, unknown billing provider #936 should be updated to reflect this
  • introduces "unique" additional options for our dropdown listing components when compared with existing lists
    • as silly as this seems, this update will affect generating future lists, and force unique qualities to be configured either in the API or GUI
      • consistency of dropdown options vs what the API provides is the underlying issue... why is the option being provided in the first place
  • marking this as blocked since "removing none" was posed as a solution without accounting for configuration

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. navigate to RHOSAK, confirm the select/dropdown only has the options displayed in the below example

Example

NONE-REMOVED-Screen Shot 2022-06-24 at 12 22 27 AM

Updates issue/story

ent-4689 aka SWATCH-93

@cdcabrera cdcabrera added bug Something isn't working blocked Prevented from continuing 202208 project phase labels Jun 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

Merging #951 (74954c9) into dev (71504ff) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #951      +/-   ##
==========================================
+ Coverage   93.94%   93.96%   +0.02%     
==========================================
  Files         129      129              
  Lines        4044     4044              
  Branches     1583     1583              
==========================================
+ Hits         3799     3800       +1     
+ Misses        227      226       -1     
  Partials       18       18              
Impacted Files Coverage Δ
src/services/rhsm/rhsmConstants.js 100.00% <ø> (ø)
src/common/helpers.js 100.00% <0.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71504ff...74954c9. Read the comment docs.

@bclarhk
Copy link

bclarhk commented Jul 25, 2022

Yep, remove none plz thx

@cdcabrera cdcabrera removed the blocked Prevented from continuing label Jul 26, 2022
@cdcabrera cdcabrera marked this pull request as ready for review July 27, 2022 16:54
@cdcabrera cdcabrera changed the title fix(rhosak): ent-4689 remove none option fix(rhosak): ent-4689 (sw-93) billing provider, remove none option Jul 27, 2022
@cdcabrera cdcabrera merged commit 2237f74 into RedHatInsights:dev Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202208 project phase bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants