Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rhsmTransformers): ent-5213 allow first dates to draw line #955

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jul 6, 2022

What's included

  • fix(rhsmTransformers): ent-5213 allow first dates to draw line
    • rhsmTransformers, shift x axis index for first dates

Notes

  • adds an additional x axis entry and tick in the event the first date with a value exists, and all subsequent dates are future dates. this allows Victory to display a line

How to test

Local run check

  1. In order to emulate this you have to add a GUI debugger date to the dotenv files. Add the following entry to a .env.local file in the root of the project
       REACT_APP_DEBUG_DEFAULT_DATETIME=20220701
    
  2. You'll also need to update the fixture associated with Instance Hours by updating the ./src/services/rhsm/rhsmServices.js file, you can find an example here
  3. update the NPM packages with $ yarn
  4. $ yarn start
  5. navigate to the RHOSAK display and confirm the graph for Instance hours matches the AFTER screenshot below

Example

BEFORE

image

AFTER

Screen Shot 2022-07-05 at 9 12 42 PM

Updates issue/story

ent-5213

* rhsmTransformers, shift x axis index for first dates
@cdcabrera cdcabrera added bug Something isn't working 202208 project phase labels Jul 6, 2022
@cdcabrera cdcabrera merged commit 5d453ea into RedHatInsights:ci Jul 6, 2022
cdcabrera added a commit that referenced this pull request Jul 11, 2022
* rhsmTransformers, shift x axis index for first dates
cdcabrera added a commit that referenced this pull request Jul 21, 2022
* rhsmTransformers, shift x axis index for first dates
cdcabrera added a commit that referenced this pull request Jul 21, 2022
* rhsmTransformers, shift x axis index for first dates
cdcabrera added a commit that referenced this pull request Aug 1, 2022
* rhsmTransformers, shift x axis index for first dates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202208 project phase bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant