Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rhelGraphCard): issues/93 remove the word daily #96

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(rhelGraphCard): issues/93 remove the word daily

How to test

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. you should be able to visually confirm the removal of the word "daily"

Example

Before

Screen Shot 2019-09-05 at 10 54 26 AM

After

Screen Shot 2019-09-05 at 10 57 57 AM

Updates issue/story

Closes #93

@codecov-io
Copy link

Codecov Report

Merging #96 into ci-beta will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           ci-beta     #96   +/-   ##
=======================================
  Coverage     90.4%   90.4%           
=======================================
  Files           26      26           
  Lines          448     448           
  Branches       109     109           
=======================================
  Hits           405     405           
  Misses          34      34           
  Partials         9       9
Impacted Files Coverage Δ
src/components/rhelGraphCard/rhelGraphCard.js 73.07% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2368dc...d58425b. Read the comment docs.

Copy link

@bclarhk bclarhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can confirm, word is gone

@cdcabrera cdcabrera merged commit 67137a6 into RedHatInsights:ci-beta Sep 5, 2019
@cdcabrera cdcabrera mentioned this pull request Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants