Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rhacs): sw-479 activate product display #965

Merged
merged 5 commits into from
Aug 29, 2022
Merged

feat(rhacs): sw-479 activate product display #965

merged 5 commits into from
Aug 29, 2022

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Aug 23, 2022 •
edited
Loading

What's included

  • fix(build): sw-460 dev local run navigation
  • fix(rhacs): sw-479 Core-hours to Cores metric
  • feat(rhacs): sw-479 activate product display
  • fix(productViews): sw-479 display types
  • chore(build): commit lint, issue number check

Notes

  • added support build working into this PR
  • with the expected influx of new products we needed a way to determine the product view template instead of relying on product ids... the fix for productViews applies either a legacy dual-axes or hourly template type.
    • these types are fluid, we can update accordingly
  • still need to confirm the metric identifier that's coming across... should be Cores

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. navigate towards http://localhost:3000/insights/subscriptions/rhacs and confirm the display shows

Example

Screen Shot 2022-08-22 at 10 36 50 PM

Updates issue/story

swatch-479

@cdcabrera cdcabrera added the 202208 project phase label Aug 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2022 •
edited
Loading

Codecov Report

Merging #965 (64bed4a) into dev (7581c2a) will decrease coverage by 0.07%.
The diff coverage is 85.36%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #965      +/-   ##
==========================================
- Coverage   93.96%   93.89%   -0.08%     
==========================================
  Files         129      130       +1     
  Lines        4045     4077      +32     
  Branches     1583     1598      +15     
==========================================
+ Hits         3801     3828      +27     
- Misses        226      231       +5     
  Partials       18       18
Impacted Files Coverage Δ
src/config/product.openshiftContainer.js 82.50% <ø> (ø)
src/config/product.openshiftDedicated.js 95.45% <ø> (ø)
src/config/product.openshiftMetrics.js 95.00% <ø> (ø)
src/config/product.rhel.js 84.09% <ø> (ø)
src/config/product.rhosak.js 82.92% <ø> (ø)
src/config/product.satellite.js 88.57% <ø> (ø)
src/config/routes.js 100.00% <ø> (ø)
src/config/product.rhacs.js 84.84% <84.84%> (ø)
src/components/productView/productView.js 93.75% <85.71%> (-0.37%) ⬇️
src/services/rhsm/rhsmConstants.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7581c2a...64bed4a. Read the comment docs.

cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Aug 23, 2022
@cdcabrera
chore(build): commit lint, issue number check (RedHatInsights#965)
dfc2c14
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Aug 23, 2022
@cdcabrera
fix(productViews): sw-479 display types (RedHatInsights#965)
c8644d5 
* config, product template display types
* productView, use display type, product id
* rhsmConstants, display types
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Aug 23, 2022
@cdcabrera
feat(rhacs): sw-479 activate product display (RedHatInsights#965)
64bed4a 
* locale, rhacs strings, vCPU hours
* config, rhacs config
* rhsmConstants, product and metric ids
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Aug 29, 2022
@cdcabrera
fix(build): sw-460 dev local run navigation (RedHatInsights#965)
f06a3d4
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Aug 29, 2022
@cdcabrera
feat(rhacs): sw-479 activate product display (RedHatInsights#965)
f70224c 
* locale, rhacs strings, vCPU hours
* config, rhacs config
* rhsmConstants, product and metric ids
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Aug 29, 2022
@cdcabrera
fix(rhacs): sw-479 Core-hours to Cores metric (RedHatInsights#965)
9df7b4e
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Aug 29, 2022
@cdcabrera
feat(rhacs): sw-479 activate product display (RedHatInsights#965)
1c0ff6e 
* locale, rhacs strings, vCPU hours
* config, rhacs config
* rhsmConstants, product and metric ids
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Aug 29, 2022
@cdcabrera
fix(rhacs): sw-479 Core-hours to Cores metric (RedHatInsights#965)
52ae5bf
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Aug 29, 2022
@cdcabrera
fix(build): sw-460 dev local run navigation (RedHatInsights#965)
ddc2dc6
@cdcabrera cdcabrera marked this pull request as ready for review August 29, 2022 17:02
@cdcabrera cdcabrera merged commit c6fe4eb into RedHatInsights:dev Aug 29, 2022
cdcabrera added a commit that referenced this pull request Aug 29, 2022
@cdcabrera
chore(build): commit lint, issue number check (#965)
4ecf03d
cdcabrera added a commit that referenced this pull request Aug 29, 2022
@cdcabrera
fix(productViews): sw-479 display types (#965)
95aa6d4 
* config, product template display types
* productView, use display type, product id
* rhsmConstants, display types
cdcabrera added a commit that referenced this pull request Aug 29, 2022
@cdcabrera
feat(rhacs): sw-479 activate product display (#965)
5734455 
* locale, rhacs strings, vCPU hours
* config, rhacs config
* rhsmConstants, product and metric ids
cdcabrera added a commit that referenced this pull request Aug 29, 2022
@cdcabrera
fix(rhacs): sw-479 Core-hours to Cores metric (#965)
a85b0a3
@cdcabrera cdcabrera mentioned this pull request Aug 31, 2022
Merged
cdcabrera added a commit that referenced this pull request Sep 1, 2022
@cdcabrera
chore(build): commit lint, issue number check (#965)
c60f733
cdcabrera added a commit that referenced this pull request Sep 1, 2022
@cdcabrera
fix(productViews): sw-479 display types (#965)
f77fcc5 
* config, product template display types
* productView, use display type, product id
* rhsmConstants, display types
cdcabrera added a commit that referenced this pull request Sep 1, 2022
@cdcabrera
feat(rhacs): sw-479 activate product display (#965)
4cdbc99 
* locale, rhacs strings, vCPU hours
* config, rhacs config
* rhsmConstants, product and metric ids
cdcabrera added a commit that referenced this pull request Sep 1, 2022
@cdcabrera
fix(rhacs): sw-479 Core-hours to Cores metric (#965)
54c8d52
cdcabrera added a commit that referenced this pull request Sep 1, 2022
@cdcabrera
fix(build): sw-460 dev local run navigation (#965)
9babc7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
202208 project phase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdcabrera @codecov-commenter