Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inventory): sw-356 empty state copy #983

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(inventory): sw-356 empty state copy

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. navigate to a product and...
    • confirm that the inventory messaging displays per the screenshot

Example

Screen Shot 2022-10-12 at 11 22 34 AM

Updates issue/story

sw-356

@cdcabrera cdcabrera added the bug Something isn't working label Oct 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #983 (3bb4363) into dev (2609829) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #983   +/-   ##
=======================================
  Coverage   93.79%   93.79%           
=======================================
  Files         129      129           
  Lines        4109     4109           
  Branches     1624     1624           
=======================================
  Hits         3854     3854           
  Misses        237      237           
  Partials       18       18           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2609829...3bb4363. Read the comment docs.

@cdcabrera cdcabrera merged commit 7d65db8 into RedHatInsights:dev Oct 12, 2022
cdcabrera added a commit that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants