[DO NOT MERGE] Add dynamic dispatch metrics #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
port-to-v1.10
Confirmed the correct `boxed` calls to log.
This one is a (rare) boxing of a static dispatch return.
Log the size of the datatype being boxed, both for inputs and returns. Also, we cannot simply add in `jl_gc_alloc`s for our extra inputs as they will actually be removed in late lowering. Instead, we simply add to an extras count of boxed inputs and extras boxed input size.
Also add an `options.h` macro -- JL_DISPATCH_LOG_BOXES -- to control the entire box logging feature.
Put the box logging feature behind JL_DISPATCH_LOG_BOXES.
JL_DISPATCH_LOG_BOXES
JL_DISPATCH_LOG_BOXES
To the logging functions. Also some cleanup.
Unsure why but it doesn't really matter.
kpamnany
force-pushed
the
kp-dispatch-metrics
branch
from
4901a19
to
10351ad
Compare
It breaks PackageCompiler in RAICode. Add `num_dynamic_dispatches` to `jl_method_t` unconditionally instead.
kpamnany
force-pushed
the
kp-dispatch-metrics
branch
from
e43ee0e
to
bbecd31
Compare
|
This PR is stale because it has been open 30 days with no activity. Comment or remove stale label, or this PR will be closed in 5 days. |
d-netto
removed
port-to-v1.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.
Cleanup of #101 + box sizes + count of generic calls.