Add --trace-dispatch
#183
Merged
Add --trace-dispatch
#183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
port-to-v1.10
kpamnany
removed
the
port-to-master
Similar to `--trace-compile`, emit the `precompile` statement for a method once, but only when it is dynamically dispatched. For this, we rename the `precompiled` field in `jl_method_instance_t` to `flags` and use bit 0 as `precompiled` and bit 1 as `dispatched`. When the method is dispatched, the `dispatched` bit is set to 1 and the precompile statement is emitted. This check is done in `jl_gf_invoke_by_method` and in the slow path (cache miss) of `jl_apply_generic`.
kpamnany
force-pushed
the
kp-add-trace-dispatch
branch
from
64aaab7
to
9d4f6b5
Compare
NHDaly
reviewed
Sep 27, 2024
Comment on lines
+2390
to
+2396
| if (!jl_has_free_typevars(mi->specTypes)) { | ||
| jl_printf(s_dispatch, "precompile("); | ||
| jl_static_show(s_dispatch, mi->specTypes); | ||
| jl_printf(s_dispatch, ")\n"); | ||
| if (s_dispatch != JL_STDERR) | ||
| ios_flush(&f_dispatch); | ||
| } |
There was a problem hiding this comment.
This is so that we only write out concrete signatures, not ones compiled by inference?
Can you add a comment indicating so? (Also in the upstream PR 🙏 )
There was a problem hiding this comment.
Actually, this is just a direct copy from record_precompile_statement. I think jl_static_show will barf if there are free type variables.
NHDaly
approved these changes
Sep 27, 2024
|
Thanks... hoping I get the okay from Jeff today. |
kpamnany
force-pushed
the
kp-add-trace-dispatch
branch
from
c89c448
to
9d4f6b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add a
--trace-dispatchcommand line argument similar to--trace-compile; the output will similarly containprecompilestatements, but for methods that are dynamically dispatched to, i.e. generically called.Checklist
Requirements for merging:
--trace-dispatchJuliaLang/julia#55848port-to-*labels that don't apply.