Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert: add more metadata #15

Merged
merged 5 commits into from
Feb 21, 2023
Merged

Conversation

simleo
Copy link
Collaborator

@simleo simleo commented Feb 21, 2023

  • Logic to add more metadata to the crate: sha1, alternateName, profile conformance
  • Fix mapping of workflow-level parameters with secondary files (cwltool only registers them for tool runs)
  • New option to add a README file

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 99.44% // Head: 99.08% // Decreases project coverage by -0.37% ⚠️

Coverage data is based on head (0e0fe2c) compared to base (928bb9d).
Patch coverage: 95.86% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   99.44%   99.08%   -0.37%     
==========================================
  Files           6        6              
  Lines        1089     1197     +108     
==========================================
+ Hits         1083     1186     +103     
- Misses          6       11       +5     
Impacted Files Coverage Δ
src/runcrate/__init__.py 98.07% <93.58%> (-0.92%) ⬇️
src/runcrate/cli.py 95.45% <100.00%> (+0.21%) ⬆️
tests/test_cli.py 100.00% <100.00%> (ø)
tests/test_cwlprov_crate_builder.py 99.83% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@simleo simleo merged commit 4078746 into ResearchObject:main Feb 21, 2023
@simleo simleo deleted the more_metadata branch February 21, 2023 10:42
@mr-c
Copy link
Contributor

mr-c commented Feb 21, 2023

Pinging @RenskeW ; I guess your table will need updating?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants