Update LUA from v5.2 to v5.4 #2524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no unsigned anymore, just integers.
Many exisiting LUA scripts are using bit32 which has been removed in LUA5.4 in favor of native language support of bitwise operations. Yet, it's easier to backport this module rather than patching all the existing LUA scripts because most of them can't be tested.
|
Sorry, this is a long PR. But that's the minimal set to make sure things are running "as before" |
|
Wow!!! lets see how much we break! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many changes needed to be made which are kept in individual commits:
lualibs/ansicolors.luawhich was written as a lua5.1 modulelualibs/dkjson.luato a more recent version, also adding support to utf-8table.unpack()instead ofunpack()lua_checkunsigned()andluaL_pushunsigned()inclient/src/scripting.cto use the APIsbit32core module which has been deprecated in favor of native support for bitwise operations (but they also moved from 32bit to 64bit integers at the same time!)