Fix SimulateIso14443aInit usage #2564
Merged
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added NULL as `uint8_t *iRats` to all invokations in armsrc/Standalone. Not sure if that is the right thing to do: The actual code checks for the presence of a special flag, but does not contain a check for NULL. IMHO adding a NULL check in `iso14443a.c` line 1259 wouldn't hurt, and could catch programming errors (flag set by accident, but NULL passed). Maybe @evildaemond wants to verify whether my fix does the right thing or if I missed something (they added the iRATs to `iso14443a.h` with 56324b1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added NULL as
uint8_t *iRatsto all invokations in armsrc/Standalone.Not sure if that is the right thing to do: The actual code checks for the presence of a special flag, but does not contain a check for NULL. IMHO adding a NULL check in
iso14443a.cline 1259 wouldn't hurt, and could catch programming errors (flag set by accident, but NULL passed).Maybe @evildaemond wants to verify whether my fix does the right thing or if I missed something (they added the iRATs to
iso14443a.hwith 56324b1).